Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 18 Jul 2017 09:14:21 +0000 (UTC)
From:      Boris Samorodov <bsam@FreeBSD.org>
To:        ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   svn commit: r446130 - in head/net-mgmt: alertmanager blackbox_exporter mysqld_exporter pushgateway unbound_exporter
Message-ID:  <201707180914.v6I9ELQd053518@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: bsam
Date: Tue Jul 18 09:14:21 2017
New Revision: 446130
URL: https://svnweb.freebsd.org/changeset/ports/446130

Log:
  Prometheus exporters and pushgateway: Strip golang binaries.
  
  TLDR; turns out to be a misconception, has gone with dinosaurs.
  Golang Project treat such cases as bugs, submit any evidence to them.
  More info: https://honnef.co/posts/2016/10/go-and-strip/
  
  Fix my port and ports I've committed yesterday.
  Bump PORTREVISION.
  
  Reported by:	swills
  Approved by:	portmgr (just fix it)

Modified:
  head/net-mgmt/alertmanager/Makefile
  head/net-mgmt/blackbox_exporter/Makefile
  head/net-mgmt/mysqld_exporter/Makefile
  head/net-mgmt/pushgateway/Makefile
  head/net-mgmt/unbound_exporter/Makefile

Modified: head/net-mgmt/alertmanager/Makefile
==============================================================================
--- head/net-mgmt/alertmanager/Makefile	Tue Jul 18 09:01:00 2017	(r446129)
+++ head/net-mgmt/alertmanager/Makefile	Tue Jul 18 09:14:21 2017	(r446130)
@@ -3,6 +3,7 @@
 
 PORTNAME=	alertmanager
 PORTVERSION=	0.5.1
+PORTREVISION=	1
 DISTVERSIONPREFIX=	v
 CATEGORIES=	net-mgmt
 
@@ -24,8 +25,6 @@ GROUPS=		alertmanager
 
 PLIST_FILES=	bin/alertmanager \
 		etc/alertmanager/alertmanager.yml.sample
-
-STRIP=		# stripping can break go binaries
 
 do-build:
 	(cd ${GO_WRKSRC}/cmd/alertmanager ; ${SETENV} ${GO_ENV} go install)

Modified: head/net-mgmt/blackbox_exporter/Makefile
==============================================================================
--- head/net-mgmt/blackbox_exporter/Makefile	Tue Jul 18 09:01:00 2017	(r446129)
+++ head/net-mgmt/blackbox_exporter/Makefile	Tue Jul 18 09:14:21 2017	(r446130)
@@ -3,6 +3,7 @@
 
 PORTNAME=	blackbox_exporter
 PORTVERSION=	0.6.0
+PORTREVISION=	1
 DISTVERSIONPREFIX=v
 CATEGORIES=	net-mgmt
 
@@ -20,8 +21,6 @@ GO_PKGNAME=	github.com/${GH_ACCOUNT}/${PORTNAME}
 GO_TARGET=	github.com/${GH_ACCOUNT}/${PORTNAME}
 
 USE_RC_SUBR=	${PORTNAME}
-
-STRIP=		# stripping can break go binaries
 
 PORTEXAMPLES=	${WRKSRC}/*.yml
 

Modified: head/net-mgmt/mysqld_exporter/Makefile
==============================================================================
--- head/net-mgmt/mysqld_exporter/Makefile	Tue Jul 18 09:01:00 2017	(r446129)
+++ head/net-mgmt/mysqld_exporter/Makefile	Tue Jul 18 09:14:21 2017	(r446130)
@@ -3,6 +3,7 @@
 
 PORTNAME=	mysqld_exporter
 PORTVERSION=	0.10.0
+PORTREVISION=	1
 DISTVERSIONPREFIX=v
 CATEGORIES=	net-mgmt
 
@@ -22,8 +23,6 @@ GO_TARGET=	github.com/${GH_ACCOUNT}/${PORTNAME}
 PLIST_FILES=	bin/mysqld_exporter
 
 USE_RC_SUBR=	mysqld_exporter
-
-STRIP=		# stripping can break go binaries
 
 do-install:
 	${INSTALL_PROGRAM} ${WRKDIR}/bin/mysqld_exporter ${STAGEDIR}${PREFIX}/bin

Modified: head/net-mgmt/pushgateway/Makefile
==============================================================================
--- head/net-mgmt/pushgateway/Makefile	Tue Jul 18 09:01:00 2017	(r446129)
+++ head/net-mgmt/pushgateway/Makefile	Tue Jul 18 09:14:21 2017	(r446130)
@@ -3,6 +3,7 @@
 
 PORTNAME=	pushgateway
 PORTVERSION=	0.3.1
+PORTREVISION=	1
 DISTVERSIONPREFIX=v
 CATEGORIES=	net-mgmt
 
@@ -21,8 +22,6 @@ USE_RC_SUBR=	pushgateway
 
 USERS=		prometheus
 GROUPS=		prometheus
-
-STRIP=		# stripping can break go binaries
 
 do-build:
 	(cd ${GO_WRKSRC} ; ${SETENV} ${GO_ENV} go install)

Modified: head/net-mgmt/unbound_exporter/Makefile
==============================================================================
--- head/net-mgmt/unbound_exporter/Makefile	Tue Jul 18 09:01:00 2017	(r446129)
+++ head/net-mgmt/unbound_exporter/Makefile	Tue Jul 18 09:14:21 2017	(r446130)
@@ -3,6 +3,7 @@
 
 PORTNAME=		unbound_exporter
 PORTVERSION=		0.1
+PORTREVISION=		1
 DISTVERSIONPREFIX=	v
 CATEGORIES=		net-mgmt
 
@@ -28,8 +29,6 @@ USE_RC_SUBR=		unbound_exporter
 
 USERS=			unbound
 GROUPS=			unbound
-
-STRIP=
 
 PLIST_FILES=		bin/unbound_exporter
 



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201707180914.v6I9ELQd053518>