From owner-freebsd-bugs Mon Jul 21 11:00:10 1997 Return-Path: Received: (from root@localhost) by hub.freebsd.org (8.8.5/8.8.5) id LAA29350 for bugs-outgoing; Mon, 21 Jul 1997 11:00:10 -0700 (PDT) Received: (from gnats@localhost) by hub.freebsd.org (8.8.5/8.8.5) id LAA29340; Mon, 21 Jul 1997 11:00:04 -0700 (PDT) Resent-Date: Mon, 21 Jul 1997 11:00:04 -0700 (PDT) Resent-Message-Id: <199707211800.LAA29340@hub.freebsd.org> Resent-From: gnats (GNATS Management) Resent-To: freebsd-bugs Resent-Reply-To: FreeBSD-gnats@FreeBSD.ORG, blank@fox.uni-trier.de Received: from sliphost37.uni-trier.de (root@sliphost37.uni-trier.de [136.199.240.37]) by hub.freebsd.org (8.8.5/8.8.5) with ESMTP id KAA28708 for ; Mon, 21 Jul 1997 10:52:58 -0700 (PDT) Received: (from blank@localhost) by sliphost37.uni-trier.de (8.8.6/8.8.6) id TAA01719; Mon, 21 Jul 1997 19:40:18 +0200 (CEST) Message-Id: <199707211740.TAA01719@sliphost37.uni-trier.de> Date: Mon, 21 Jul 1997 19:40:18 +0200 (CEST) From: blank@fox.uni-trier.de Reply-To: blank@fox.uni-trier.de To: FreeBSD-gnats-submit@FreeBSD.ORG X-Send-Pr-Version: 3.2 Subject: bin/4135: ftpd in RELENG_2_2 outputs wrong hostname Sender: owner-freebsd-bugs@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk >Number: 4135 >Category: bin >Synopsis: ftpd: missing hostname in "quote help" output >Confidential: no >Severity: non-critical >Priority: medium >Responsible: freebsd-bugs >State: open >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Mon Jul 21 11:00:02 PDT 1997 >Last-Modified: >Originator: Sascha Blank >Organization: >Release: FreeBSD 2.2-STABLE i386 >Environment: FreeBSD 2.2-RELENG, the relevant source files in /usr/src/libexec/ftpd: Makefile: $Id: Makefile,v 1.17.2.3 1997/05/10 19:48:12 davidn Exp $ ftpcmd.y: $Id: ftpcmd.y,v 1.8 1996/09/22 21:53:23 wosch Exp $ ftpd.c: $Id: ftpd.c,v 1.25.2.9 1997/05/21 23:27:12 danny exp $ The ftp daemon is built with VIRTUAL_HOSTING defined which is the default for 2.2-RELENG. >Description: When I type "quote help" at the ftp prompt I get this: ftp> quote help 214- The following commands are recognized (* =>'s unimplemented). USER PORT STOR MSAM* RNTO NLST MKD CDUP PASS PASV APPE MRSQ* ABOR SITE XMKD XCUP ACCT* TYPE MLFL* MRCP* DELE SYST RMD STOU SMNT* STRU MAIL* ALLO CWD STAT XRMD SIZE REIN* MODE MSND* REST XCWD HELP PWD MDTM QUIT RETR MSOM* RNFR LIST NOOP XPWD 214 Direct comments to ftp-bugs@`. The malformed email address is the result of a wrong external variable declaration. After correcting this declaration the output is correct again: ftp> quote help 214- The following commands are recognized (* =>'s unimplemented). USER PORT STOR MSAM* RNTO NLST MKD CDUP PASS PASV APPE MRSQ* ABOR SITE XMKD XCUP ACCT* TYPE MLFL* MRCP* DELE SYST RMD STOU SMNT* STRU MAIL* ALLO CWD STAT XRMD SIZE REIN* MODE MSND* REST XCWD HELP PWD MDTM QUIT RETR MSOM* RNFR LIST NOOP XPWD 214 Direct comments to ftp-bugs@sliphost37.uni-trier.de. Note: This bug might be present in 3.0-CURRENT as well. >How-To-Repeat: See description above. >Fix: The following small patch corrects the problem: blank in /usr/src/libexec/ftpd (330): diff -c ftpcmd.y.CURRENT ftpcmd.y *** ftpcmd.y.CURRENT Mon Jul 21 19:10:32 1997 --- ftpcmd.y Mon Jul 21 19:28:34 1997 *************** *** 80,86 **** extern int timeout; extern int maxtimeout; extern int pdata; ! extern char hostname[], remotehost[]; extern char proctitle[]; extern int usedefault; extern int transflag; --- 80,91 ---- extern int timeout; extern int maxtimeout; extern int pdata; ! #ifdef VIRTUAL_HOSTING ! extern char *hostname; ! #else ! extern char hostname[]; ! #endif ! extern char remotehost[]; extern char proctitle[]; extern int usedefault; extern int transflag; -- Sascha Blank - mailto:blank@fox.uni-trier.de Student and System Administrator at the University of Trier, Germany Finger my account to receive my Public PGP key I don't speak for my employers, they don't pay me enough for that. >Audit-Trail: >Unformatted: