From owner-freebsd-python@FreeBSD.ORG Fri Sep 5 15:11:59 2014 Return-Path: <owner-freebsd-python@FreeBSD.ORG> Delivered-To: python@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 283103DE for <python@FreeBSD.org>; Fri, 5 Sep 2014 15:11:59 +0000 (UTC) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id E9C70123C for <python@FreeBSD.org>; Fri, 5 Sep 2014 15:11:58 +0000 (UTC) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.14.9/8.14.9) with ESMTP id s85FBwYS061510 for <python@FreeBSD.org>; Fri, 5 Sep 2014 15:11:58 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: python@FreeBSD.org Subject: [Bug 193313] [NEW PORT] www/py-wsgidav: wsgi implemented DAV Date: Fri, 05 Sep 2014 15:11:59 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports Tree X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: yan_jingfeng@yahoo.com X-Bugzilla-Status: Open X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: python@FreeBSD.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: <bug-193313-21822-6hLIS9ZT0A@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-193313-21822@https.bugs.freebsd.org/bugzilla/> References: <bug-193313-21822@https.bugs.freebsd.org/bugzilla/> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-python@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: FreeBSD-specific Python issues <freebsd-python.freebsd.org> List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-python>, <mailto:freebsd-python-request@freebsd.org?subject=unsubscribe> List-Archive: <http://lists.freebsd.org/pipermail/freebsd-python/> List-Post: <mailto:freebsd-python@freebsd.org> List-Help: <mailto:freebsd-python-request@freebsd.org?subject=help> List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-python>, <mailto:freebsd-python-request@freebsd.org?subject=subscribe> X-List-Received-Date: Fri, 05 Sep 2014 15:11:59 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=193313 --- Comment #4 from Jingfeng Yan <yan_jingfeng@yahoo.com> --- (In reply to Kubilay Kocak from comment #3) > Thanks for your submission Jingfeng. Thank you for your reviewing. > > A quick note that the following entries have been deprecated [1] > > * USE_PYTHON= 2 > * USE_PYDISTUTILS= yes > * PYDISTUTILS_AUTOPLIST= yes > > [1] See /Mk/Uses/python.mk for more information > [2] Add DEVELOPER=yes to your make.conf to enable additional QA checks > Fully accepted. Will update the port shar file in one or two minutes. > Additional review items: > > * LICENSE_FILE is missing LICENSE_FILE seems not to be mandatory and some py modules do not have full text of license. For example, zope213... The only LICENSE info only be carried in PKG-INFO file. > * You can use CHEESESHOP for MASTER_SITES which sets MASTER_SITE_SUBDIR Good learning, it makes life easier. I did struggle with upper/lowercase of MASTER_SITE_SUBDIR when I ported. > * Is there a reason the tests directory cant remain? Some of python modules have test directory. When install, it first detects __init__.py exists in the tests directory (some other modules have installed tests). The other thing that I don't understand well, all the python modules' tests directory install to the same location, and is there any way to avoid name conflict? __init__.py is place holder in most of cases (but it could do something, too). How about other file names. If there is better way to keep the tests directory, I will follow. > * Attach portlint -AC output :) will do. > > Feel free to update your attachment with those changes, and you may also use > svn diff to assist review by our committers no svn diff, but diff this time. Will do in the future. -- You are receiving this mail because: You are the assignee for the bug.