From owner-svn-ports-all@FreeBSD.ORG  Fri Mar  7 08:57:44 2014
Return-Path: <owner-svn-ports-all@FreeBSD.ORG>
Delivered-To: svn-ports-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id BAEF2465;
 Fri,  7 Mar 2014 08:57:44 +0000 (UTC)
Received: from prod2.absolight.net (mx3.absolight.net
 [IPv6:2a01:678:2:100::25])
 (using TLSv1 with cipher ADH-CAMELLIA256-SHA (256/256 bits))
 (No client certificate requested)
 by mx1.freebsd.org (Postfix) with ESMTPS id 7D1ADFC8;
 Fri,  7 Mar 2014 08:57:44 +0000 (UTC)
Received: from prod2.absolight.net (localhost [127.0.0.1])
 by prod2.absolight.net (Postfix) with ESMTP id AE553BDC2E;
 Fri,  7 Mar 2014 09:57:41 +0100 (CET)
Received: from atuin.in.mat.cc (atuin.in.mat.cc [79.143.241.205])
 by prod2.absolight.net (Postfix) with ESMTPA id A57A1BDC24;
 Fri,  7 Mar 2014 09:57:41 +0100 (CET)
Received: from localhost (localhost [127.0.0.1])
 by atuin.in.mat.cc (Postfix) with ESMTP id 097E1D09B3FD;
 Fri,  7 Mar 2014 09:57:39 +0100 (CET)
Date: Fri, 07 Mar 2014 09:57:35 +0100
From: Mathieu Arnold <mat@FreeBSD.org>
To: Alexey Dokuchaev <danfe@FreeBSD.org>,
 "Lev A. Serebryakov" <lev@FreeBSD.org>
Subject: Re: svn commit: r345100 - in head/devel/libopencm3: . files
Message-ID: <1150A77479CA8C9AD82E5874@atuin.in.mat.cc>
In-Reply-To: <20140307051744.GA9177@FreeBSD.org>
References: <201402191508.s1JF8uOK086607@svn.freebsd.org>
 <20140307051744.GA9177@FreeBSD.org>
X-Mailer: Mulberry/4.0.8 (Mac OS X)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org,
 ports-committers@freebsd.org
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 07 Mar 2014 08:57:44 -0000



+--On 7 mars 2014 05:17:44 +0000 Alexey Dokuchaev <danfe@FreeBSD.org> wrote:
| On Wed, Feb 19, 2014 at 03:08:56PM +0000, Lev A. Serebryakov wrote:
|> New Revision: 345100
|> URL: http://svnweb.freebsd.org/changeset/ports/345100
|> QAT: https://qat.redports.org/buildarchive/r345100/
|> 
|>  @@ -1,4 +1,4 @@
|>  -#!/usr/bin/env python
|> -+#!/usr/bin/env python2
|> ++#! /usr/bin/env /usr/local/bin/python2
| 
| Can you elaborate on this change a bit?  env(1) is mostly used in this
| situation to rely on PATH value in the environment, to avoid having to
| specify full path to the executable, but you do precisely this.  Is it
| a typo, or you rely to some other variable passed via environment?  It
| also contains a style bug (space after #!).  Original line looked good
| already (/usr/local/bin is in our PATH), unless I'm missing something.
| 
|> -+#!/usr/bin/python2
|> ++#! /usr/local/bin/python2
| 
| This one makes more sense (modulo the style bug), but then again: what
| is wrong with canonical '#!/usr/bin/env python2' ?

Actually, none make sense, The first one was already ok, and the second is
wrong.
But all in all, it doesn't matter, because you should USES=shebangfix.

-- 
Mathieu Arnold