From owner-freebsd-current@FreeBSD.ORG  Tue Oct 21 16:40:59 2003
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id F10E016A4B3
	for <current@freebsd.org>; Tue, 21 Oct 2003 16:40:59 -0700 (PDT)
Received: from web40303.mail.yahoo.com (web40303.mail.yahoo.com
	[66.218.78.82])	by mx1.FreeBSD.org (Postfix) with SMTP id C542D43F93
	for <current@freebsd.org>; Tue, 21 Oct 2003 16:40:57 -0700 (PDT)
	(envelope-from m_evmenkin@yahoo.com)
Message-ID: <20031021234057.85729.qmail@web40303.mail.yahoo.com>
Received: from [66.35.239.94] by web40303.mail.yahoo.com via HTTP;
	Tue, 21 Oct 2003 16:40:57 PDT
Date: Tue, 21 Oct 2003 16:40:57 -0700 (PDT)
From: Maksim Yevmenkin <m_evmenkin@yahoo.com>
To: "Simon L. Nielsen" <simon@FreeBSD.org>
In-Reply-To: <20031021215707.GC393@arthur.nitro.dk>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
cc: imp@freebsd.org
cc: current@freebsd.org
cc: jhay@freebsd.org
Subject: Re: [PATCH] connect bluetooth configs and examples to the build
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 21 Oct 2003 23:41:00 -0000

Simon,

> > i'd like to commit attached patch. the purpose is to connect etc/bluetooth
> > and share/examples/netgraph/bluetooth to the build. please review and let
> > me know if i missed anything.
> >
> > Index: src/etc/bluetooth/Makefile
> > ===================================================================
> > RCS file: src/etc/bluetooth/Makefile
> > diff -N src/etc/bluetooth/Makefile
> > --- /dev/null	1 Jan 1970 00:00:00 -0000
> > +++ src/etc/bluetooth/Makefile	21 Oct 2003 20:20:03 -0000
> > @@ -0,0 +1,10 @@
> > +# $Id: Makefile,v 1.1 2003/10/20 16:48:45 max Exp $
> > +# $FreeBSD$
> > +
> > +FILESDIR=		${DESTDIR}/etc/bluetooth
> 
> I'm rather sure that you shouldn't include DESTDIR, since bsd.files.mk
> does that. 

got it. thanks for noticing this :)

> Also you should probably use the style from
> style.Makefile(5) for new Makefile's.

could you please be more specific? i took a quick look at style.Makefile(5)
page and could not find anything related to my case.

thanks,
max

__________________________________
Do you Yahoo!?
The New Yahoo! Shopping - with improved product search
http://shopping.yahoo.com