From owner-freebsd-hackers@FreeBSD.ORG Wed Mar 12 00:20:11 2014 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 90F4C419 for ; Wed, 12 Mar 2014 00:20:11 +0000 (UTC) Received: from mail-pa0-f41.google.com (mail-pa0-f41.google.com [209.85.220.41]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 6449087A for ; Wed, 12 Mar 2014 00:20:11 +0000 (UTC) Received: by mail-pa0-f41.google.com with SMTP id fa1so284574pad.28 for ; Tue, 11 Mar 2014 17:20:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=gT6PCsODKUcfsR+Cph6AnvLZZDYOX/LJgc6gYG4ev/8=; b=gDZ6L3g62zgU/b541SAourKJwVKdxdDe+mC38bI9FlKXhjcttZnSs3QjQysr2p/Io4 MjDT5kz0/1r1YYdS+wVsa2kYwPuxVV8zq+EStJgWFhTldiPLzNHxyWJfnmZu5DLwfWo7 kc3E1ihsJngn0KjYBiHm073DDVtw18r7cuXb/MheJpJvg+DYJJhWvsFU330EDDJRp7CF mIWuetBKq+qUVoh/0Ren9fb0YjlzEudc4bX9p3U4KtrIhPm+0VYYysjjZUWacKg+pq5W mX8Kiy7sEczKGm1R85dawVebXkDAX9JblVaxwMeqrflKwcXHfm2g2NIHyKyAJ6JiLu+/ einw== X-Gm-Message-State: ALoCoQl1A4bnnNi6t6emDgt/qOFKU5XYHonOK1unU2LJ+aT+IPVpWs+mUKJ94RttuLv8/mH1U/jH X-Received: by 10.68.239.137 with SMTP id vs9mr1221718pbc.84.1394583605621; Tue, 11 Mar 2014 17:20:05 -0700 (PDT) Received: from cmeyer.west.isilon.com (c-67-182-131-225.hsd1.wa.comcast.net. [67.182.131.225]) by mx.google.com with ESMTPSA id jd5sm1276051pbb.18.2014.03.11.17.20.03 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 11 Mar 2014 17:20:04 -0700 (PDT) From: Conrad Meyer To: freebsd-hackers@freebsd.org Subject: [PATCH 3/5] hwpmc_piv.c: pmc_p4_initialize: Use correct type for sizeof() in malloc() Date: Tue, 11 Mar 2014 17:19:41 -0700 Message-Id: <1394583583-19023-4-git-send-email-conrad.meyer@isilon.com> X-Mailer: git-send-email 1.8.5.3 In-Reply-To: <1394583583-19023-1-git-send-email-conrad.meyer@isilon.com> References: <1394583583-19023-1-git-send-email-conrad.meyer@isilon.com> X-Mailman-Approved-At: Wed, 12 Mar 2014 02:10:19 +0000 Cc: Conrad Meyer , Jeffrey Roberson X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 12 Mar 2014 00:20:11 -0000 Both types are pointers, so this isn't a big deal. But Clang static analysis reports it, so we might as well correct it (and it's the right thing to do.) Signed-off-by: Conrad Meyer --- sys/dev/hwpmc/hwpmc_piv.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/sys/dev/hwpmc/hwpmc_piv.c b/sys/dev/hwpmc/hwpmc_piv.c index 3137ea2..e72c38a 100644 --- a/sys/dev/hwpmc/hwpmc_piv.c +++ b/sys/dev/hwpmc/hwpmc_piv.c @@ -1620,8 +1620,7 @@ pmc_p4_initialize(struct pmc_mdep *md, int ncpus) PMCDBG(MDP,INI,1, "%s", "p4-initialize"); /* Allocate space for pointers to per-cpu descriptors. */ - p4_pcpu = malloc(sizeof(struct p4_cpu **) * ncpus, M_PMC, - M_ZERO|M_WAITOK); + p4_pcpu = malloc(sizeof(*p4_pcpu) * ncpus, M_PMC, M_ZERO|M_WAITOK); /* Fill in the class dependent descriptor. */ pcd = &md->pmd_classdep[PMC_MDEP_CLASS_INDEX_P4]; -- 1.8.5.3