From owner-svn-ports-head@freebsd.org  Mon Aug  3 11:25:28 2020
Return-Path: <owner-svn-ports-head@freebsd.org>
Delivered-To: svn-ports-head@mailman.nyi.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.nyi.freebsd.org (Postfix) with ESMTP id 65E0A37755C;
 Mon,  3 Aug 2020 11:25:28 +0000 (UTC)
 (envelope-from rodrigo@freebsd.org)
Received: from smtp.osorio.me (mvd.osorio.me [5.196.94.126])
 by mx1.freebsd.org (Postfix) with ESMTP id 4BKwY41zHlz4ft0;
 Mon,  3 Aug 2020 11:25:27 +0000 (UTC)
 (envelope-from rodrigo@freebsd.org)
Received: from [192.168.1.100] (pop.92-184-110-47.mobile.abo.orange.fr
 [92.184.110.47])
 (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
 key-exchange X25519 server-signature RSA-PSS (4096 bits))
 (No client certificate requested)
 by smtp.osorio.me (Postfix) with ESMTPSA id 7B6B2E1A7F;
 Mon,  3 Aug 2020 11:25:25 +0000 (UTC)
Subject: Re: svn commit: r543580 - in head/net/rsync: . files
To: Adam Weinberger <adamw@adamw.org>, Cy Schubert <Cy.Schubert@cschubert.com>
Cc: ports-committers <ports-committers@freebsd.org>,
 svn-ports-all <svn-ports-all@freebsd.org>,
 svn-ports-head <svn-ports-head@freebsd.org>
References: <202007280659.06S6xa4M088583@repo.freebsd.org>
 <CAP7rwcji4YRd5EYVw=7ym77VuCc=KwjwdUi8JCBceKqufWPJWg@mail.gmail.com>
 <CAP7rwcjBe9x7my-gKNNQaRa3CCeydTsJ6X7StOoEM=EXN-O9WA@mail.gmail.com>
 <202007281441.06SEf15s070772@slippy.cwsent.com>
 <CAP7rwcjoMDzgP44hLUBD7De=jZcUoKJjEoMTqib9f2C9Fv1-EA@mail.gmail.com>
From: Rodrigo Osorio <rodrigo@freebsd.org>
Message-ID: <f6cecdfb-1425-f90f-694d-720fffdb7d3c@freebsd.org>
Date: Mon, 3 Aug 2020 13:24:58 +0200
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <CAP7rwcjoMDzgP44hLUBD7De=jZcUoKJjEoMTqib9f2C9Fv1-EA@mail.gmail.com>
Content-Language: en-US
X-Rspamd-Queue-Id: 4BKwY41zHlz4ft0
X-Spamd-Bar: /
Authentication-Results: mx1.freebsd.org;
	none
X-Spamd-Result: default: False [0.00 / 15.00];
 local_wl_from(0.00)[freebsd.org];
 ASN(0.00)[asn:16276, ipnet:5.196.0.0/16, country:FR]
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
X-Content-Filtered-By: Mailman/MimeDel 2.1.33
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.33
Precedence: list
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-head>, 
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head/>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 03 Aug 2020 11:25:28 -0000


On 7/28/20 10:27 PM, Adam Weinberger wrote:
>>> Past the fetch failure, this also doesn't configure. Is it possible
>>> that a patch didn't get added?
>>>
>>> # Adam
>>>
>>>
>>>    checking whether to enable xxhash checksum support... no
>>>    configure.sh: error: Failed to find xxhash.h for xxhash checksum support.
>>>    Use --disable-xxhash to continue without it.
>>>    ===>  Script "configure" failed unexpectedly.
>>>    Please report the problem torodrigo@FreeBSD.org  [maintainer] and attach th
>>> e
>>>    "/wrkdirs/usr/ports/net/rsync/work/rsync-3.2.2/config.log" including the
>>>    output of the failure of your make command. Also, it might be a good idea t
>>> o
>>>    provide an overview of all packages installed on your system (e.g. a
>>>    /usr/local/sbin/pkg-static info -g -Ea).
>>>    *** Error code 1
>>>
>>>    Stop.
>>>    make: stopped in /usr/ports/net/rsync
>>>    =>> Cleaning up wrkdir
>>>    ===>  Cleaning for rsync-3.2.2
>> Looks like it's missing a DEPENDS.
> It depends on xxhash. I suspect it's missing a configure arg.
>
> # Adam

Yes I didn't try to disable default options, sorry for that.
BTW, do we have a way to test options during build ?

-- rodrigo