From owner-freebsd-hackers@FreeBSD.ORG Wed May 1 21:38:12 2013 Return-Path: Delivered-To: hackers@freebsd.org Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id 23F29FE0 for ; Wed, 1 May 2013 21:38:12 +0000 (UTC) (envelope-from brooks@lor.one-eyed-alien.net) Received: from lor.one-eyed-alien.net (lor.one-eyed-alien.net [69.66.77.232]) by mx1.freebsd.org (Postfix) with ESMTP id 6625C1499 for ; Wed, 1 May 2013 21:38:11 +0000 (UTC) Received: from lor.one-eyed-alien.net (localhost [127.0.0.1]) by lor.one-eyed-alien.net (8.14.5/8.14.5) with ESMTP id r41LcAgj048491; Wed, 1 May 2013 16:38:10 -0500 (CDT) (envelope-from brooks@lor.one-eyed-alien.net) Received: (from brooks@localhost) by lor.one-eyed-alien.net (8.14.5/8.14.5/Submit) id r41LcA1Z048490; Wed, 1 May 2013 16:38:10 -0500 (CDT) (envelope-from brooks) Date: Wed, 1 May 2013 16:38:10 -0500 From: Brooks Davis To: Alfred Perlstein Subject: Re: potential future proofing fix for aicasm build. Message-ID: <20130501213810.GB45806@lor.one-eyed-alien.net> References: <51814686.2060805@ixsystems.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="IiVenqGWf+H9Y6IX" Content-Disposition: inline In-Reply-To: <51814686.2060805@ixsystems.com> User-Agent: Mutt/1.5.21 (2010-09-15) Cc: hackers@freebsd.org X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 May 2013 21:38:12 -0000 --IiVenqGWf+H9Y6IX Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, May 01, 2013 at 09:44:54AM -0700, Alfred Perlstein wrote: > Hey folks, >=20 > I took a shot at fixing this issue with building aicasm as part of=20 > "buildkernel" of an older 9.0 src on a machine running HEAD. >=20 > aicasm.o: In function `__getCurrentRuneLocale': >=20 > /usr/include/runetype.h:96: undefined reference to `_ThreadRuneLocale' >=20 > The issue seems to be two-fold: >=20 > 1) Paths are not fully set to pick up the bootstrap tools needed to build. > 2) include files use the host's instead of the build trees. >=20 > The first problem is fixed by changing setting of PATH from=20 > "${BPATH}:${PATH}" to ${TMPPATH}. >=20 > The second is fixed by using -nostdinc and setting strict include paths= =20 > using -I directives to the compiler: >=20 > CFLAGS=3D"-nostdinc -I${WORLDTMP}/usr/include -I. -I${KERNSRCDIR}/dev/aic= 7xxx/aicasm" This seems basically ok. > Can I get review on this patch? The line wrapping bugs should have been fixed before posting, but it otherwise looks fine. I do wonder why we don't just install aicasm in the base and bootstrap it in the unlikely event that it changes in an important way. A quick scan of svn log suggests that gibbs fixed a bug in mid-2010 and the last non-build system or portability change was circa 2003 so I don't think we'd break old-style kernel builds at a rate worth worrying about. -- Brooks --IiVenqGWf+H9Y6IX Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (FreeBSD) iD8DBQFRgYtBXY6L6fI4GtQRAoThAJwKy93MRB2wLXBJdHteqE0xdRgargCgvYX7 K4FL50WYZPqf3YrvKdv8oUI= =w0hK -----END PGP SIGNATURE----- --IiVenqGWf+H9Y6IX--