From owner-dev-commits-src-all@freebsd.org Tue Jan 19 16:43:08 2021 Return-Path: Delivered-To: dev-commits-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id DCC1B4D885A for ; Tue, 19 Jan 2021 16:43:08 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4DKvbc5mtjz3tsJ for ; Tue, 19 Jan 2021 16:43:08 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Received: by mail-wm1-f44.google.com with SMTP id e15so378306wme.0 for ; Tue, 19 Jan 2021 08:43:08 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=zhlMH9WR8J01fXeB/Qp5YzevfF6sQmustZ4f06RZOcU=; b=lwX1FlNU5OMawXzOuo/9YPAkP5VDIdPt5i743wo7rHk2KJ6cMUkifJyPZN1DHXLhjZ kxnYu0rRCYtZ2uxNPbP3SNIEEexYki0MWvSLm9+qfFwylKf2LMWJSkr1eHE/zTxKLEiO povibjUqf64WZ+WzpccXTXkmLpquIBmL2Ct79liBDaf6dS1RHg4ShRrm42RqsvSFiI3u hf47A3Z+d/kcb2G/5zi57iUBD3eGjtVYk0CSN4AjyzwcsYW29cJQPDMsxcoPOv4CTKFh 2LrptXBaDAXiu9pOA6GVS+guOcnmXpcBE4vAK1PewNGvV0iilDnwcAJGRC/zYHS5lw0/ MNIw== X-Gm-Message-State: AOAM533zdn//3un/M5ZsBkmRodVUI3orUY/1UF3HZCJksdSY0swOS049 oP4CvrnFvuZlbPxBn/Mq5iyGJiY2Wcf/33wN X-Google-Smtp-Source: ABdhPJx9Vavuyqg+8MO69lStCGWCcu8Q46ZSErbyPAWpY0lroBk4CYTAd3h9KDvdHx5hvAPuHyFCBQ== X-Received: by 2002:a05:600c:618:: with SMTP id o24mr480523wmm.82.1611074586850; Tue, 19 Jan 2021 08:43:06 -0800 (PST) Received: from [192.168.149.251] (trinity-students-nat.trin.cam.ac.uk. [131.111.193.104]) by smtp.gmail.com with ESMTPSA id h15sm36269764wru.4.2021.01.19.08.43.06 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 19 Jan 2021 08:43:06 -0800 (PST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.4\)) Subject: Re: git: 248f0cabca75 - main - make maximum interrupt number tunable on ARM, ARM64, MIPS, and RISC-V From: Jessica Clarke In-Reply-To: <202101190036.10J0aj3O033256@gitrepo.freebsd.org> Date: Tue, 19 Jan 2021 16:43:05 +0000 Cc: "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Content-Transfer-Encoding: 7bit Message-Id: <8FE79D0F-602A-4C98-893A-806E72ED991B@freebsd.org> References: <202101190036.10J0aj3O033256@gitrepo.freebsd.org> To: Oleksandr Tymoshenko X-Mailer: Apple Mail (2.3608.120.23.2.4) X-Rspamd-Queue-Id: 4DKvbc5mtjz3tsJ X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-BeenThere: dev-commits-src-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for all branches of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Jan 2021 16:43:08 -0000 On 19 Jan 2021, at 00:36, Oleksandr Tymoshenko wrote: > @@ -142,21 +143,15 @@ static bool irq_assign_cpu = false; > #endif > #endif > > -/* > - * - 2 counters for each I/O interrupt. > - * - MAXCPU counters for each IPI counters for SMP. > - */ > -#ifdef SMP > -#define INTRCNT_COUNT (NIRQ * 2 + INTR_IPI_COUNT * MAXCPU) > -#else > -#define INTRCNT_COUNT (NIRQ * 2) > -#endif > +int intr_nirq = NIRQ; > +SYSCTL_UINT(_machdep, OID_AUTO, nirq, CTLFLAG_RDTUN, &intr_nirq, 0, > + "Number of IRQs"); Unsigned integer, given the SYSCTL_UINT? What's stopping us from dynamically resizing rather than forcing the user to use a tunable (which also means that, in practice, the limit will remain unchanged, because you want GENERIC kernels to work out of the box)? Jess