Skip site navigation (1)Skip section navigation (2) 
Date:      Fri, 30 May 2003 16:23:52 -0700 (PDT)
From:      Juli Mallett <jmallett@FreeBSD.org>
To:        Perforce Change Reviews <perforce@freebsd.org>
Subject:   PERFORCE change 32132 for review
Message-ID:  <200305302323.h4UNNqLc080067@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help 
http://perforce.freebsd.org/chv.cgi?CH=32132

Change 32132 by jmallett@jmallett_dalek on 2003/05/30 16:23:36

	When NetBSD uses 'unsinged' they usually mean "THIS HOLDS AN
	ADDRESS," grrr.  Use register_t for those things.
	
	Other uses of unsigned should be instruction_t or something,
	and I'm sure I will make them such in time.  db_insn_t?

Affected files ...

.. //depot/projects/mips/sys/mips/mips/db_interface.c#3 edit
.. //depot/projects/mips/sys/mips/mips/db_trace.c#2 edit

Differences ...

==== //depot/projects/mips/sys/mips/mips/db_interface.c#3 (text+ko) ====

@@ -294,16 +294,16 @@
 
 		for (i = 0; i < mips_num_tlb_entries; i++) {
 			mips64_TLBRead(i, &tlb);
-			db_printf("TLB%c%2d Hi 0x%08x ",
+			db_printf("TLB%c%2d Hi 0x%016lx ",
 			(tlb.tlb_lo0 | tlb.tlb_lo1) & MIPS3_PG_V ? ' ' : '*',
 				i, tlb.tlb_hi);
-			db_printf("Lo0=0x%08x %c%c attr %x ",
-				(unsigned)mips_tlbpfn_to_paddr(tlb.tlb_lo0),
+			db_printf("Lo0=0x%016lx %c%c attr %x ",
+				mips_tlbpfn_to_paddr(tlb.tlb_lo0),
 				(tlb.tlb_lo0 & MIPS3_PG_D) ? 'D' : ' ',
 				(tlb.tlb_lo0 & MIPS3_PG_G) ? 'G' : ' ',
 				(tlb.tlb_lo0 >> 3) & 7);
-			db_printf("Lo1=0x%08x %c%c attr %x sz=%x\n",
-				(unsigned)mips_tlbpfn_to_paddr(tlb.tlb_lo1),
+			db_printf("Lo1=0x%016lx %c%c attr %x sz=%x\n",
+				mips_tlbpfn_to_paddr(tlb.tlb_lo1),
 				(tlb.tlb_lo1 & MIPS3_PG_D) ? 'D' : ' ',
 				(tlb.tlb_lo1 & MIPS3_PG_G) ? 'G' : ' ',
 				(tlb.tlb_lo1 >> 3) & 7,
@@ -682,7 +682,7 @@
 	case OP_J:
 	case OP_JAL:
 		nextpc = (inst.JType.target << 2) |
-			((unsigned)instpc & 0xF0000000);
+			((register_t)instpc & 0xF0000000);
 		break;
 
 	case OP_BEQ:

==== //depot/projects/mips/sys/mips/mips/db_trace.c#2 (text+ko) ====

@@ -124,7 +124,7 @@
 #define	MIPS_JR_RA	0x03e00008	/* instruction code for jr ra */
 #define	MIPS_JR_K0	0x03400008	/* instruction code for jr k0 */
 #define	MIPS_ERET	0x42000018	/* instruction code for eret */
-	unsigned va, pc, ra, sp, func;
+	register_t va, pc, ra, sp, func;
 	int insn;
 	InstFmt i;
 	int stacksize;

Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200305302323.h4UNNqLc080067>