From owner-freebsd-current@FreeBSD.ORG Tue Jun 29 20:37:55 2004 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5526016A4CE; Tue, 29 Jun 2004 20:37:55 +0000 (GMT) Received: from rwcrmhc11.comcast.net (rwcrmhc11.comcast.net [204.127.198.35]) by mx1.FreeBSD.org (Postfix) with ESMTP id 076F443D39; Tue, 29 Jun 2004 20:37:55 +0000 (GMT) (envelope-from julian@elischer.org) Received: from interjet.elischer.org ([24.7.73.28]) by comcast.net (rwcrmhc11) with ESMTP id <200406292037490130056l3pe>; Tue, 29 Jun 2004 20:37:54 +0000 Received: from localhost (localhost.elischer.org [127.0.0.1]) by InterJet.elischer.org (8.9.1a/8.9.1) with ESMTP id NAA61901; Tue, 29 Jun 2004 13:37:48 -0700 (PDT) Date: Tue, 29 Jun 2004 13:37:47 -0700 (PDT) From: Julian Elischer To: "Bjoern A. Zeeb" In-Reply-To: Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII cc: Pawel Jakub Dawidek cc: FreeBSD current users cc: "Bjoern A. Zeeb" Subject: Re: jail getfsstat patches. X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 29 Jun 2004 20:37:55 -0000 YECH I need to read what I type.. On Tue, 29 Jun 2004, Julian Elischer wrote: > > > On Tue, 29 Jun 2004, Bjoern A. Zeeb wrote: > > > On Tue, 29 Jun 2004, Julian Elischer wrote: > > > > > > +> do you have a 4.x version? > > > > > > > > I don't have 4.x boxes, so I can't prepare one for 4.x. Could you try to > > > > port it? It should be easy. > > > > > > I was looking at the original patch for 4.x (the one that is a kld > > > module). > > > > the one from pjd I think this is as I do not have an 4.x verison > > online. > > > > > here is my (I hope) fixed version... > > > > why do you work on this ? wouldn't backporting the actual patch be > > better instead of s.th. different ? > > I need a solution for my "users" here now (today) so I thought that teh the > fact that pjd had a 4.x lkm module already available > would allow me to give them that solution immediatly > while we work on getting a permanent solution in the tree(s). > As it happenned our app complained because teh number of filesystems the > reported when buf == NULL was not the same as the number of > filesystems for which data was actually provided. > > While fixing that I noticed the fact that 'copyout' was not being used > to manipulate the strings so I fixed that two.. too > > I will now look at the newer code, and my users are happy :-) > > pjd can now at least replace teh version he has on his page with teh the the > fixed version, except that I just realised that '[f]statfs()' > also probably needs to be fixed to not write directly to userland. > > > > > there are of course some differences in both struct prison and statfs > > but it should be doable; making a KLD then is s.th. very simple from > > what I had learned. > > I'll be looking at the new code in a few days.. > I have to MFC USB stuff today (we need it :-/ ) > > > > > > -- > > Bjoern A. Zeeb bzeeb at Zabbadoz dot NeT > > > > _______________________________________________ > freebsd-current@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-current > To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org" >