From owner-cvs-src@FreeBSD.ORG Mon Mar 26 15:36:39 2007 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 746C916A403; Mon, 26 Mar 2007 15:36:39 +0000 (UTC) (envelope-from keramida@freebsd.org) Received: from igloo.linux.gr (igloo.linux.gr [62.1.205.36]) by mx1.freebsd.org (Postfix) with ESMTP id C9C7713C43E; Mon, 26 Mar 2007 15:36:38 +0000 (UTC) (envelope-from keramida@freebsd.org) Received: from kobe.laptop (host5.bedc.ondsl.gr [62.103.39.229]) (authenticated bits=128) by igloo.linux.gr (8.13.8/8.13.8/Debian-3) with ESMTP id l2QFPZv7021015 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Mon, 26 Mar 2007 18:25:42 +0300 Received: from kobe.laptop (kobe.laptop [127.0.0.1]) by kobe.laptop (8.13.8/8.13.8) with ESMTP id l2QFPGDQ001704; Mon, 26 Mar 2007 18:25:29 +0300 (EEST) (envelope-from keramida@freebsd.org) Received: (from keramida@localhost) by kobe.laptop (8.13.8/8.13.8/Submit) id l2QFPGOl001703; Mon, 26 Mar 2007 18:25:16 +0300 (EEST) (envelope-from keramida@freebsd.org) Date: Mon, 26 Mar 2007 18:25:16 +0300 From: Giorgos Keramidas To: Andre Oppermann Message-ID: <20070326152515.GA1621@kobe.laptop> References: <200703252327.l2PNRR38029221@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200703252327.l2PNRR38029221@repoman.freebsd.org> X-Hellug-MailScanner: Found to be clean X-Hellug-MailScanner-SpamCheck: not spam, SpamAssassin (not cached, score=-3.774, required 5, autolearn=not spam, ALL_TRUSTED -1.80, AWL 0.62, BAYES_00 -2.60) X-Hellug-MailScanner-From: keramida@freebsd.org X-Spam-Status: No Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/netinet tcp_sack.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Mar 2007 15:36:39 -0000 On 2007-03-25 23:27, Andre Oppermann wrote: > andre 2007-03-25 23:27:27 UTC > > FreeBSD src repository > > Modified files: > sys/netinet tcp_sack.c > Log: > In tcp_sack_doack() remove too tight KASSERT() added in last revision. This > function may be called without any TCP SACK option blocks present. Protect > iteration over SACK option blocks by checking for SACK options present flag > first. > > Bug reported by: wkoszek, keramida, Nicolas Blais > > Revision Changes Path > 1.36 +16 -14 src/sys/netinet/tcp_sack.c Fantastic, thanks! I'm now running a new kernel, compiled from sources which have been updated to "Mon Mar 26 09:10:28 2007 +0000" sources, and no panics have been observed so far with net.inet.tcp.sack.enable=1 :-)