Date: Sun, 31 Mar 2024 22:23:54 +0200 From: Daniel Engberg <daniel.engberg.lists@pyret.net> To: Po-Chuan Hsieh <sunpoet@freebsd.org> Cc: Daniel Engberg <diizzy@freebsd.org>, ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 1a2f57d29bcc - main - multimedia/libzen: Adjust package version Message-ID: <1c1b29f5766a456eb07bc3f303b9970f@mail.infomaniak.com> In-Reply-To: <CAMHz58Q9i6jv-%2BAmPYni7MStiL1o3Ez2udPooqwA=0iqjXr7rg@mail.gmail.com> References: <202403282226.42SMQmaW063083@gitrepo.freebsd.org> <CAMHz58Q9i6jv-%2BAmPYni7MStiL1o3Ez2udPooqwA=0iqjXr7rg@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 2024-03-31T21:31:09.000+02:00, Po-Chuan Hsieh <sunpoet@freebsd.org> wrot= e: > On Fri, Mar 29, 2024 at 6:26=E2=80=AFAM Daniel Engberg <diizzy@freebsd.o= rg> wrote: >=20 >=20 > > The branch main has been updated by diizzy: > >=20 > > URL: > > https://cgit.FreeBSD.org/ports/commit/?id=3D1a2f57d29bcc8c5cd279739989= 09c5e519f90457 > >=20 > > commit 1a2f57d29bcc8c5cd27973998909c5e519f90457 > > Author: Daniel Engberg <diizzy@FreeBSD.org> > > AuthorDate: 2024-03-28 22:06:52 +0000 > > Commit: Daniel Engberg <diizzy@FreeBSD.org> > > CommitDate: 2024-03-28 22:25:58 +0000 > >=20 > > multimedia/libzen: Adjust package version > >=20 > > Upstream bundles libzen (named ZenLib upstream) both separately an= d > > as a all-in-one bundle with mediainfo (multimedia/mediainfo) relea= ses. > > Libzen do not share the same versioning schema as mediainfo and he= nce > > shouldn't use it. Upstream bundles snapshots of libzen however onl= y > > release versions are tracked (current version is defined as 0.4.41= ). > > Current release bundle archive ships the latest commit of libzen > > available and following Porters Handbook append commit date to > > release version. Worth noting is that separate version provided > > on upstream's download page corresponds to the tagged version on > > GitHub. > >=20 > > Sources: > > https://github.com/MediaArea/ZenLib > > https://mediaarea.net/en/MediaInfo/Download/Source > >=20 > > PR: 276754 > > Approved by: portmgr (maintainer timeout, 1+ month) > >=20 > =20 > I don't see any patch files for this commit on Bugzilla. The only one is > incorrect and outdated. I replied to you the same day and as explained and linked to in the PR upst= ream doesn't use your claimed versioning and it's neither a "private" libra= ry (which doesn't matter) which you didn't take any action on for over a mo= nth. >=20 > --- >=20 > > multimedia/libzen/Makefile | 10 ++++++---- > > 1 file changed, 6 insertions(+), 4 deletions(-) > >=20 > > diff --git a/multimedia/libzen/Makefile b/multimedia/libzen/Makefile > > index 365fa2ba5d98..60cb49bdc993 100644 > > --- a/multimedia/libzen/Makefile > > +++ b/multimedia/libzen/Makefile > > @@ -1,10 +1,11 @@ > > PORTNAME=3D libzen > > -PORTVERSION=3D 24.01.1 > > -PORTEPOCH=3D 1 > > +DISTVERSION=3D 0.4.41.20240118 > > +PORTREVISION=3D 1 > >=20 > =20 > FYI, since you bumped PORTEPOCH, you don't need to bump PORTREVISION. Noted, thanks >=20 >=20 >=20 > > +PORTEPOCH=3D 2 > > CATEGORIES=3D multimedia > > -MASTER_SITES=3D > > https://mediaarea.net/download/binary/mediainfo/${PORTVERSION}/ \ > > +MASTER_SITES=3D > > https://mediaarea.net/download/binary/mediainfo/${UPSTREAM_BUNDLE_VERS= ION}/ > > \ > > LOCAL/sunpoet > > -DISTNAME=3D MediaInfo_CLI_${PORTVERSION}_GNU_FromSource > > +DISTNAME=3D MediaInfo_CLI_${UPSTREAM_BUNDLE_VERSION}_GNU_FromSou= rce > >=20 > > MAINTAINER=3D sunpoet@FreeBSD.org > > COMMENT=3D ZenLib used by MediaInfo and its library > > @@ -19,6 +20,7 @@ USES=3D compiler:c++11-lang dos2unix libtool > > pathfix tar:xz > > CONFIGURE_ARGS=3D --enable-shared --enable-static > > GNU_CONFIGURE=3D yes > > INSTALL_TARGET=3D install-strip > > +UPSTREAM_BUNDLE_VERSION=3D 24.01.1 > > USE_LDCONFIG=3D yes > >=20 > > WRKSRC=3D > > ${WRKDIR}/MediaInfo_CLI_GNU_FromSource/ZenLib/Project/GNU/Library > >=20 >=20 =20 Best regards, Daniel
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1c1b29f5766a456eb07bc3f303b9970f>