From nobody Mon Jan 8 21:33:28 2024 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4T86kP0jKFz56sLv; Mon, 8 Jan 2024 21:33:33 +0000 (UTC) (envelope-from jbeich@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2610:1c1:1:6074::16:84]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4T86kN5yCXz4lr5; Mon, 8 Jan 2024 21:33:32 +0000 (UTC) (envelope-from jbeich@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1704749612; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=judgTK8n325ih1THVH6sPmApg2KQZXORksSGfSWB1Gk=; b=ZDoQhtxg4m3/E08wYJSmG2VWJJz3LCuCA10KGsz1Dg20MzKrkT/oINxfwwX0s73NW/RRGq EqipiQQSHBRdxrBuMT4FjRGcKV4w/kQTFpCpmF+m8UHFbCyqUFMnUtb3FcGcRJSXJreuYT cE8C/E0M8PnvKOZyFZsR0B6Qrw5cZi1TEjDhwvGTUyix+e1HSs4vSN8qzp5mHNp6oSBEPE NDu/yxW+8ER/fHvndtisD8o8bv+k66mG7DSGGiHVAmRJYPGdgOmuz7kHAIfJ7GNBIDYrrm NJX2jOwB7nMJr3K2A/XY78e01ebyOCEcL9qsXNeIRsH2w3fW5YEn4JVRY4Hycg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1704749612; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=judgTK8n325ih1THVH6sPmApg2KQZXORksSGfSWB1Gk=; b=CDc1vdQmMchSd3nqPB+71hk92EMnbs9uubVPPcJf2jp07fO9Z5+jpakU48uLWCsHc55o/w nVAQrwqDBSlTXlbdpjsNOxpFiwuMRVL6Dxc7OdaGTAoTY5TYW0Iv547kB9nBhRNHCutHuc 43aTM20THf1Os768K2hftxW9A/1eLcDK26ugUTZst364ZdqxXLoKMx+aMai1bfxvd3CWp4 bkhGptzQvD93+04EmHo3E7XUTjHgxu3Iq9uPOB1KjiOnfcbfwfxbtOV/YiMkeovCS9PUU2 /Qoit/QNvIQV0lQ8HucXH75od0AE5F5Sfa0gqqUXkGfOuzEcx7RGuCC03PsAnQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1704749612; a=rsa-sha256; cv=none; b=PETKwmlbVJCr7lxErxlNgW4gi/h3BFFUHWzhGzB17fvtvpdC5hxp8HmlkM4D0p2grIFfD2 Z5XlqhxkcJVV3smgrPW3rI+AarMYwcGc0S5OX2xB/zndCSqsEZL8aALpUfGkWYBi4zCUwE Ym+2HLy7Np8SQ9NNTGCskL0tqOX33Pco/iWASCtWm2y42KkwGjotFzJ3YfEG1LusbsUqRD qkBv/pURNFZxbjG2TudDTPieKrU2bl7ML6wEb36eRD295lxgcMZZhswqF7fRSo+7tc6LYv pI4KhtjJRoVlCK9yMFV+aPFpyTCWG4acw5nIbMJBupD9UbhOsgsXlRQnkUj69Q== Received: by freefall.freebsd.org (Postfix, from userid 1354) id 8647A6F18; Mon, 8 Jan 2024 21:33:32 +0000 (UTC) From: Jan Beich To: Robert Nagy Cc: ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org Subject: Re: git: 5d97e86feed9 - main - www/*chromium: unbreak arm64 by implementing the missing cpudetect code In-Reply-To: <202401082110.408LA9x0079225@gitrepo.freebsd.org> (Robert Nagy's message of "Mon, 8 Jan 2024 21:10:09 GMT") References: <202401082110.408LA9x0079225@gitrepo.freebsd.org> Date: Mon, 08 Jan 2024 22:33:28 +0100 Message-ID: List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-main@freebsd.org X-BeenThere: dev-commits-ports-main@freebsd.org MIME-Version: 1.0 Content-Type: text/plain Robert Nagy writes: > diff --git a/www/chromium/files/patch-third__party_libvpx_source_libvpx_vpx__ports_aarch64__cpudetect.c b/www/chromium/files/patch-third__party_libvpx_source_libvpx_vpx__ports_aarch64__cpudetect.c > new file mode 100644 > index 000000000000..92163a805c0c > --- /dev/null > +++ b/www/chromium/files/patch-third__party_libvpx_source_libvpx_vpx__ports_aarch64__cpudetect.c > @@ -0,0 +1,20 @@ > +--- third_party/libvpx/source/libvpx/vpx_ports/aarch64_cpudetect.c.orig 2024-01-08 12:52:53 UTC > ++++ third_party/libvpx/source/libvpx/vpx_ports/aarch64_cpudetect.c > +@@ -153,7 +153,16 @@ static int arm_get_cpu_caps(void) { > + return flags; > + } > + > +-#else // end __Fuchsia__ > ++#elif defined(__FreeBSD__) // end __Fuchsia__ > ++ > ++int arm_get_cpu_caps(void) { > ++ int flags = 0; > ++#if HAVE_NEON > ++ flags |= HAS_NEON; // Neon is mandatory in Armv8.0-A. > ++#endif // HAVE_NEON > ++ return flags; > ++} > ++#else // end __FreeBSD__ > + #error \ > + "Runtime CPU detection selected, but no CPU detection method available" \ > + "for your platform. Rerun configure with --disable-runtime-cpu-detect." > diff --git a/www/ungoogled-chromium/files/patch-third__party_libvpx_source_libvpx_vpx__ports_aarch64__cpudetect.c b/www/ungoogled-chromium/files/patch-third__party_libvpx_source_libvpx_vpx__ports_aarch64__cpudetect.c Better sync with multimedia/aom/files/patch-aom__ports_aarch64__cpudetect.c libvpx has some aarch64 SIMD code not supported by aarch32 e.g., vpx_dsp/vpx_dsp.mk 143:DSP_SRCS-$(HAVE_NEON_I8MM) += arm/vpx_convolve8_neon_i8mm.c 144:DSP_SRCS-$(HAVE_NEON_I8MM) += arm/vpx_convolve_neon_i8mm.c vpx_dsp/vpx_dsp.mk 40:DSP_SRCS-$(HAVE_NEON_DOTPROD) += arm/sse_neon_dotprod.c 141:DSP_SRCS-$(HAVE_NEON_DOTPROD) += arm/vpx_convolve8_neon_dotprod.c 142:DSP_SRCS-$(HAVE_NEON_DOTPROD) += arm/vpx_convolve_neon_dotprod.c 381:DSP_SRCS-$(HAVE_NEON_DOTPROD) += arm/sad4d_neon_dotprod.c 383:DSP_SRCS-$(HAVE_NEON_DOTPROD) += arm/sad_neon_dotprod.c 426:DSP_SRCS-$(HAVE_NEON_DOTPROD) += arm/variance_neon_dotprod.c