From owner-svn-src-head@FreeBSD.ORG Wed Aug 21 22:02:42 2013 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 3CF689DA; Wed, 21 Aug 2013 22:02:42 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: from mail-wi0-x236.google.com (mail-wi0-x236.google.com [IPv6:2a00:1450:400c:c05::236]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 3D95F2FC0; Wed, 21 Aug 2013 22:02:41 +0000 (UTC) Received: by mail-wi0-f182.google.com with SMTP id hi8so1024829wib.9 for ; Wed, 21 Aug 2013 15:02:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=M+cbVNOB1/ZFmrquzueSBVeE20/rMYY1HouxmkdEMeQ=; b=yFSDS+HDsXi7K5mjAB/Vtc4Reg62uyKNJRx0HkCY7qDEV6ndXdRoIt9H2aSwvxdoAA E2MGvnqyn8+cW1sy0a5yIQsnqvc3z2P2ACy4fwnAi9hmBc9exjt4MMyHxZHGAikGJV1J WR4oj9NIQEMzSojuJ9YhuZnhLvoHtFWbi+84Y+VJVugjYLwTfCMvRDTuKR5O5W0tdIAY oJ3+vM/RyGDmkjvdbDuUrIpvoivMige5o09Yw4cxRAgL+K3A4geWgtMKtrXHMOAOcFI7 DXcPzKkmQkhEFE8wsTEDIwTZmUg3Td0BKcecpJC46mFj/l97W6RgtusJtY2kNdv7ayDa wt4g== MIME-Version: 1.0 X-Received: by 10.180.211.206 with SMTP id ne14mr7148439wic.30.1377122559348; Wed, 21 Aug 2013 15:02:39 -0700 (PDT) Sender: adrian.chadd@gmail.com Received: by 10.217.116.136 with HTTP; Wed, 21 Aug 2013 15:02:39 -0700 (PDT) In-Reply-To: References: <201308212147.r7LLlu6V016807@svn.freebsd.org> Date: Wed, 21 Aug 2013 15:02:39 -0700 X-Google-Sender-Auth: gbnu2QAkSFN4dkZ0pezUrIHJTIQ Message-ID: Subject: Re: svn commit: r254616 - head/sys/dev/hwpmc From: Adrian Chadd To: Davide Italiano Content-Type: text/plain; charset=ISO-8859-1 X-Content-Filtered-By: Mailman/MimeDel 2.1.14 Cc: "svn-src-head@freebsd.org" , "svn-src-all@freebsd.org" , "src-committers@freebsd.org" X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Aug 2013 22:02:42 -0000 i'll talk with you/hiren/{MANPAGE_PEOPLE} once my current run of "figuring out what the hell" is done. That way the updates can be done in one big hit. Thanks -adrian On 21 August 2013 14:59, Davide Italiano wrote: > On Wed, Aug 21, 2013 at 2:52 PM, Davide Italiano > wrote: > > On Wed, Aug 21, 2013 at 2:47 PM, Adrian Chadd > wrote: > >> Author: adrian > >> Date: Wed Aug 21 21:47:56 2013 > >> New Revision: 254616 > >> URL: http://svnweb.freebsd.org/changeset/base/254616 > >> > >> Log: > >> Change the name of this particular event to reflect the name used in > >> Linux and Intel examples. > >> > >> Sourced: > >> > >> * https://github.com/andikleen/pmu-tools/blob/master/snb-client.csv > >> * http://software.intel.com/en-us/comment/1747932#comment-1747932 > >> > >> Note: > >> > >> * It's not currently in the Intel SDM; I need to chase down what's > >> going on. > >> > >> Tested: > >> > >> * Sandy Bridge > >> > >> Modified: > >> head/sys/dev/hwpmc/pmc_events.h > >> > >> Modified: head/sys/dev/hwpmc/pmc_events.h > >> > ============================================================================== > >> --- head/sys/dev/hwpmc/pmc_events.h Wed Aug 21 21:30:56 2013 > (r254615) > >> +++ head/sys/dev/hwpmc/pmc_events.h Wed Aug 21 21:47:56 2013 > (r254616) > >> @@ -3304,7 +3304,7 @@ __PMC_EV_ALIAS("MEM_LOAD_UOPS_LLC_HIT_RE > >> IAP_EVENT_D2H_04H) > \ > >> __PMC_EV_ALIAS("MEM_LOAD_UOPS_LLC_HIT_RETIRED.XSNP_NONE", > \ > >> IAP_EVENT_D2H_08H) > \ > >> -__PMC_EV_ALIAS("MEM_LOAD_UOPS_LLC_HIT_RETIRED.LLC_MISS", > \ > >> +__PMC_EV_ALIAS("MEM_LOAD_UOPS_MISC_RETIRED.LLC_MISS", > \ > >> IAP_EVENT_D4H_02H) > \ > >> __PMC_EV_ALIAS("L2_TRANS.DEMAND_DATA_RD", IAP_EVENT_F0H_01H) > \ > >> __PMC_EV_ALIAS("L2_TRANS.RFO", IAP_EVENT_F0H_02H) > \ > >> @@ -3538,7 +3538,7 @@ __PMC_EV_ALIAS("MEM_LOAD_UOPS_LLC_HIT_RE > >> IAP_EVENT_D2H_08H) > \ > >> __PMC_EV_ALIAS("MEM_LOAD_UOPS_LLC_HIT_RETIRED.ALL", > \ > >> IAP_EVENT_D2H_0FH) > \ > >> -__PMC_EV_ALIAS("MEM_LOAD_UOPS_LLC_HIT_RETIRED.LLC_MISS", > \ > >> +__PMC_EV_ALIAS("MEM_LOAD_UOPS_MISC_RETIRED.LLC_MISS", \ > >> IAP_EVENT_D4H_02H) > \ > >> __PMC_EV_ALIAS("MEM_LOAD_UOPS_LLC_MISS_RETIRED.LOCAL_DRAM", > \ > >> IAP_EVENT_D3H_01H) > \ > > > > Can you update the manpage as well? > > > > -- > > Davide > > > > "There are no solved problems; there are only problems that are more > > or less solved" -- Henri Poincare > > Also for r254476, as already requested by Hiren, because everyone > looks at the manpage to understand what metrice the event measures > before running pmcstat, so having manpages update when new events are > added is almost necessary. > > Thanks, > > -- > Davide > > "There are no solved problems; there are only problems that are more > or less solved" -- Henri Poincare >