Date: Thu, 13 Nov 2003 23:34:56 +0100 From: Oliver Eikemeier <eikemeier@fillmore-labs.com> To: obrien@FreeBSD.org Cc: FreeBSD-gnats-submit@FreeBSD.org Subject: Re: ports/59254: ports that write something after bsd.port.mk Message-ID: <3FB40710.8010409@fillmore-labs.com> In-Reply-To: <20031113164741.GA33494@dragon.nuxi.com> References: <3FB39FB5.5000209@fillmore-labs.com> <20031113164741.GA33494@dragon.nuxi.com>
next in thread | previous in thread | raw e-mail | index | archive | help
David O'Brien wrote:
>>Even though this may be an easy solution for the needs of your port, please
>>think about an other way to do it.
>>[...]
>>obrien@FreeBSD.org
>> - shells/bash2
>> - vietnamese/unicode-uhoai
>
> Trust me I have tried to find other ways. Please send patches.
> For Bash yes bsd.port.mk is broken. I've tried to get it fixed and I
> don't care to fight that fight anymore.
Hi David,
thank you for your quick feedback. Please find attached the patches for both of
your Makefiles. I hope they work, I couldn't really test unicode-uhoai,
unfortunately I don't speak vietnamese. You might want to check anyway, because
there is a `@dirrm lib/X11/fonts/TrueType/vietnamese-unicode' in pkg-plist, but
I couldn't find where the port created it.
You are right with CONFIGURE_TARGET, 359 ports use a workaround, thanks again
for bringing this up. I'm using this workaround myself in the OpenLDAP ports,
and PR 52917 seems to deal with it. At least it should be easy to remove the
workaround from those ports, they all use the same assignment, so it's just a
simple search-and-replace.
Regards
Oliver
--- afterinclude.patch begins here ---
diff -u shells/bash2/Makefile.orig shells/bash2/Makefile
--- shells/bash2/Makefile.orig 19 May 2003 21:33:35 -0000
+++ shells/bash2/Makefile 13 Nov 2003 22:15:06 -0000
@@ -37,6 +37,8 @@
CONFIGURE_ENV= LDFLAGS=-static
MAN1= bash.1 bashbug.1
+CONFIGURE_TARGET= --build=${MACHINE_ARCH}-portbld-freebsd${OSREL}
+
.if defined(WITH_NET_REDIRECTIONS)
CONFIGURE_ARGS+= --enable-net-redirections
.endif
@@ -63,5 +65,3 @@
.endif
.include <bsd.port.post.mk>
-
-CONFIGURE_TARGET:= --build=${CONFIGURE_TARGET}
diff -u vietnamese/unicode-uhoai/Makefile.orig vietnamese/unicode-uhoai/Makefile
--- vietnamese/unicode-uhoai/Makefile.orig 7 Mar 2003 06:11:48 -0000
+++ vietnamese/unicode-uhoai/Makefile 13 Nov 2003 22:14:09 -0000
@@ -20,6 +20,8 @@
USE_X_PREFIX= yes
NO_BUILD= taken care of in do-install target
+EXTRACT_BEFORE_ARGS= -qoL
+
.include <bsd.port.pre.mk>
BUILD_DEPENDS= ttmkfdir:${PORTSDIR}/x11-fonts/ttmkfdir
@@ -36,5 +38,3 @@
${SH} ${PKGINSTALL} ${PKGNAME} POST-INSTALL
.include <bsd.port.post.mk>
-
-EXTRACT_BEFORE_ARGS+= -L
--- afterinclude.patch ends here ---
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3FB40710.8010409>