From owner-freebsd-rc@FreeBSD.ORG Sat Dec 24 16:57:26 2011 Return-Path: Delivered-To: freebsd-rc@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 690501065672; Sat, 24 Dec 2011 16:57:26 +0000 (UTC) (envelope-from lars@e-new.0x20.net) Received: from mail.0x20.net (mail.0x20.net [IPv6:2001:aa8:fffb:1::3]) by mx1.freebsd.org (Postfix) with ESMTP id B0F348FC0A; Sat, 24 Dec 2011 16:57:25 +0000 (UTC) Received: from mail.0x20.net (mail.0x20.net [217.69.76.211]) by mail.0x20.net (Postfix) with ESMTP id 01F166A61CD; Sat, 24 Dec 2011 17:57:25 +0100 (CET) X-Virus-Scanned: amavisd-new at mail.0x20.net Received: from mail.0x20.net ([217.69.76.211]) by mail.0x20.net (mail.0x20.net [217.69.76.211]) (amavisd-new, port 10024) with ESMTP id XrHXA7Fd-b2Q; Sat, 24 Dec 2011 17:57:24 +0100 (CET) Received: from e-new.0x20.net (mail.0x20.net [IPv6:2001:aa8:fffb:1::3]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.0x20.net (Postfix) with ESMTPS id B59DE6A61CB; Sat, 24 Dec 2011 17:57:24 +0100 (CET) Received: from e-new.0x20.net (localhost [127.0.0.1]) by e-new.0x20.net (8.14.4/8.14.4) with ESMTP id pBOGvOhb093313; Sat, 24 Dec 2011 17:57:24 +0100 (CET) (envelope-from lars@e-new.0x20.net) Received: (from lars@localhost) by e-new.0x20.net (8.14.4/8.14.4/Submit) id pBOGvLaW092756; Sat, 24 Dec 2011 17:57:21 +0100 (CET) (envelope-from lars) Date: Sat, 24 Dec 2011 17:57:21 +0100 From: Lars Engels To: Warner Losh Message-ID: <20111224165721.GZ13272@e-new.0x20.net> References: <201112241230.pBOCUF3h064098@freefall.freebsd.org> <74F7E2CE-89DC-4F64-9A50-71B9FD458025@bsdimp.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="nktOf83SvqltY3iw" Content-Disposition: inline In-Reply-To: <74F7E2CE-89DC-4F64-9A50-71B9FD458025@bsdimp.com> X-Editor: VIM - Vi IMproved 7.3 X-Operation-System: FreeBSD 8.2-RELEASE-p3 User-Agent: Mutt/1.5.21 (2010-09-15) Cc: Chris Rees , Maxim Ignatenko , freebsd-rc@FreeBSD.org Subject: Re: conf/163508: [rc.subr] [patch] Add " enable" and " disable" commands to rc.subr X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 24 Dec 2011 16:57:26 -0000 --nktOf83SvqltY3iw Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Dec 24, 2011 at 09:48:37AM -0700, Warner Losh wrote: >=20 > On Dec 24, 2011, at 6:15 AM, Chris Rees wrote: >=20 > > On 24 December 2011 12:30, Maxim Ignatenko wrote: > >> The following reply was made to PR conf/163508; it has been noted by G= NATS. > >>=20 > >> From: Maxim Ignatenko > >> To: Doug Barton > >> Cc: bug-followup@freebsd.org > >> Subject: Re: conf/163508: [rc.subr] [patch] Add "enable" and > >> "disable" commands to rc.subr > >> Date: Sat, 24 Dec 2011 14:20:19 +0200 > >>=20 > >> On 24 December 2011 04:15, Doug Barton wrote: > >> > This idea has been considered before and rejected because it's too > >> > difficult to catch all the corner cases, and actually editing a con= fig > >> > file is not really all that hard of a thing to do. > >> > > >>=20 > >> The idea was to make enabling/disabling services less error-prone. It > >> don't need to catch _all_ corner cases, because if administrator do > >> something unusual with startup configuration he should be able to > >> manipulate it in proper way, or even have tools that do something > >> similar. > >> Proposed patch handles /etc/rc.conf, /etc/rc.conf.local and > >> /etc/rc.conf.d/* properly (I hope), so it should fit nicely in 95% of > >> cases. > >> Doing `service someserive enable` is much faster and less error-prone > >> that `service someservice rcvar ; echo someservicercvar_enable=3DYES = >> > >> /etc/rc.conf` > >=20 > > Disagree, sorry. > >=20 > > If we're going to implement these ideas we should do it properly, not > > for 95% of cases. >=20 > A lot depends on what those 5% of the cases are. Absent an > implementation to throw stones at, such criticism is premature. If > the 5% of cases are when someone has done something complicated to the > rc.conf file, then I don't care: they won't use this interface and we > can detect this case and do nothing. If the 5% of the cases are when > someone has enabled ntpd, then that would be a non-starter. Yup, let's better fix the 5% of special cases where the new features doesn't work. I know and like the "enable / disable" arguments to "svcadm" from Solaris and miss it on FreeBSD. --nktOf83SvqltY3iw Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.18 (FreeBSD) iEYEARECAAYFAk72BHEACgkQKc512sD3afiRSwCgu/6K5RF2XKkjGA8Q9+io2Cr2 vToAoKPSMX0sQkD8Zm3kWYY1j8R0ezM4 =Nvau -----END PGP SIGNATURE----- --nktOf83SvqltY3iw--