From owner-svn-src-all@FreeBSD.ORG Thu Jun 10 19:38:08 2010 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 071761065673; Thu, 10 Jun 2010 19:38:08 +0000 (UTC) (envelope-from mjacob@FreeBSD.org) Received: from svn.freebsd.org (unknown [IPv6:2001:4f8:fff6::2c]) by mx1.freebsd.org (Postfix) with ESMTP id EABB08FC14; Thu, 10 Jun 2010 19:38:07 +0000 (UTC) Received: from svn.freebsd.org (localhost [127.0.0.1]) by svn.freebsd.org (8.14.3/8.14.3) with ESMTP id o5AJc7mj044901; Thu, 10 Jun 2010 19:38:07 GMT (envelope-from mjacob@svn.freebsd.org) Received: (from mjacob@localhost) by svn.freebsd.org (8.14.3/8.14.3/Submit) id o5AJc7CT044899; Thu, 10 Jun 2010 19:38:07 GMT (envelope-from mjacob@svn.freebsd.org) Message-Id: <201006101938.o5AJc7CT044899@svn.freebsd.org> From: Matt Jacob Date: Thu, 10 Jun 2010 19:38:07 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org X-SVN-Group: head MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: Subject: svn commit: r208997 - head/sys/dev/isp X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Jun 2010 19:38:08 -0000 Author: mjacob Date: Thu Jun 10 19:38:07 2010 New Revision: 208997 URL: http://svn.freebsd.org/changeset/base/208997 Log: Don't pass a buffer directly as a printflike format string. Found by: clang MFC after: 1 month Modified: head/sys/dev/isp/isp_library.c Modified: head/sys/dev/isp/isp_library.c ============================================================================== --- head/sys/dev/isp/isp_library.c Thu Jun 10 19:11:00 2010 (r208996) +++ head/sys/dev/isp/isp_library.c Thu Jun 10 19:38:07 2010 (r208997) @@ -344,7 +344,7 @@ isp_print_qentry(ispsoftc_t *isp, const for (j = 0; j < (QENTRY_LEN >> 2); j++) { ISP_SNPRINTF(buf, TBA, "%s %02x", buf, ptr[amt++] & 0xff); } - isp_prt(isp, ISP_LOGALL, buf); + isp_prt(isp, ISP_LOGALL, "%s", buf); } }