From owner-cvs-all@FreeBSD.ORG Fri Nov 4 07:44:32 2011 Return-Path: Delivered-To: cvs-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id B51B11065738; Fri, 4 Nov 2011 07:44:32 +0000 (UTC) (envelope-from stas@FreeBSD.org) Received: from mx0.deglitch.com (cl-414.sto-01.se.sixxs.net [IPv6:2001:16d8:ff00:19d::2]) by mx1.freebsd.org (Postfix) with ESMTP id D77828FC0A; Fri, 4 Nov 2011 07:44:31 +0000 (UTC) Received: from orion.SpringDaemons.com (c-76-102-116-104.hsd1.ca.comcast.net [76.102.116.104]) by mx0.deglitch.com (Postfix) with ESMTPA id C00F28FC36; Fri, 4 Nov 2011 11:44:30 +0400 (MSK) Received: from orion (localhost [127.0.0.1]) by orion.SpringDaemons.com (Postfix) with SMTP id E596C3A736; Fri, 4 Nov 2011 00:45:52 -0700 (PDT) Date: Fri, 4 Nov 2011 00:45:52 -0700 From: Stanislav Sedov To: Alexey Dokuchaev Message-Id: <20111104004552.e5eafd8e.stas@FreeBSD.org> In-Reply-To: <20111104073501.GA83593@FreeBSD.org> References: <201111040341.pA43fLVC046402@repoman.freebsd.org> <20111104002027.b2e8b1bf.stas@FreeBSD.org> <20111104073501.GA83593@FreeBSD.org> Organization: The FreeBSD Project X-Mailer: carrier-pigeon Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/graphics/lcms2 Makefile X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: **OBSOLETE** CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Nov 2011 07:44:32 -0000 On Fri, 4 Nov 2011 07:35:01 +0000 Alexey Dokuchaev mentioned: > On Fri, Nov 04, 2011 at 12:20:27AM -0700, Stanislav Sedov wrote: > > On Fri, 4 Nov 2011 03:41:21 +0000 (UTC) > > Alexey Dokuchaev mentioned: > > > - Use more standard MANPREFIX instead of MAN1PREFIX which also does not > > > seem to be documented anywhere > > > > It is actually documented in bsd.port.mk, and I don't see a reason to > > Hmm, you're right, it is mentioned in bpm, but I find it a bit hard to > understand: > > # MANPREFIX - The directory prefix for ${MAN} and ${MLINKS}. > # Default: ${PREFIX} > # MANPREFIX > # - If manual pages of some sections install in different > # locations than others, use these. > # Default: ${MANPREFIX} > > In particular, I don't quite get this "some sections install in different > locations than others" part. Why so complicated? What exactly does it > suppose to mean? I have no idea, ask portmgr@. > > > change it to MANPREFIX, as MAN1PREFIX has more semantical information > > in it and correct here, since the manpages installed are meant for the > > section 1 of the manual. > > So how come if it is correct for section N of the manual to use MANPREFIX > is it only used in bsd.perl.mk? Frankly speaking I've never seen this > variable until today, which means vast majority of ports do not use it... It doesn't make something correct if everybody uses it. I'm not even saing that using MANPREFIX is wrong. It just seems to me that I don't think killing off the correct semantical information from the Makefile is the right thing to do. If hypotetically in the future the FreeBSD project decides to use a different prefix for MAN1 this port will work automatically. OTOH I don't really care -- I don't use ports personally anymore. It was just a suggestion, as I think that MAN1PREFIX is there for a reason. -- Stanislav Sedov ST4096-RIPE () ascii ribbon campaign - against html e-mail /\ www.asciiribbon.org - against proprietary attachments