From owner-svn-src-all@FreeBSD.ORG Tue Nov 6 22:50:44 2012 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 0A4E8313; Tue, 6 Nov 2012 22:50:44 +0000 (UTC) (envelope-from minimarmot@gmail.com) Received: from mail-pb0-f54.google.com (mail-pb0-f54.google.com [209.85.160.54]) by mx1.freebsd.org (Postfix) with ESMTP id BB3148FC14; Tue, 6 Nov 2012 22:50:43 +0000 (UTC) Received: by mail-pb0-f54.google.com with SMTP id rp8so793729pbb.13 for ; Tue, 06 Nov 2012 14:50:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=Amw4HSwJGGcephSXhBcvjTN3AEOF8IKYXTP/++pchmE=; b=jMkVaBFWWHxCvGn8qkxmrVX0BsjIqbmCfyVM+YwDWKAtVXYanhHN/DiqF7Cdqn5eVA fQ7GBrmZsSYi84woS2Xs8QNIDOfFuiUT72Foa3SsLTQQdsTgh87CC2jnXBnZx+2fxhz9 re1NIQ4Vu1MipQq/kowYQP2GDaYoMknspnZs8V3OPr1pIbXOGIRvDxKNkX40R4+xCIGs gtT5eAlFF7+fa5R5AXXCYYIDK6sPqUONe9ggeSEx+I7z/gpsZxwB8X1zxdXIqL6KqTg5 qA6qfwb5UKaBmrOHuf2fc8R3FcG/jLG/DCwq/qR5Ps3sbsxddQ+Lqo2dNqKbeqh/ME04 7XWQ== MIME-Version: 1.0 Received: by 10.69.1.9 with SMTP id bc9mr7765431pbd.61.1352242243276; Tue, 06 Nov 2012 14:50:43 -0800 (PST) Received: by 10.66.148.227 with HTTP; Tue, 6 Nov 2012 14:50:43 -0800 (PST) In-Reply-To: <201210221750.q9MHot26061585@svn.freebsd.org> References: <201210221750.q9MHot26061585@svn.freebsd.org> Date: Tue, 6 Nov 2012 17:50:43 -0500 Message-ID: Subject: Re: svn commit: r241896 - in head: . cddl/contrib/opensolaris/lib/libzpool/common/sys share/man/man9 sys/cam/ctl sys/cddl/compat/opensolaris/kern sys/cddl/compat/opensolaris/sys sys/cddl/contrib/openso... From: Ben Kaduk To: Konstantin Belousov Content-Type: text/plain; charset=ISO-8859-1 Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Nov 2012 22:50:44 -0000 On Mon, Oct 22, 2012 at 1:50 PM, Konstantin Belousov wrote: > Author: kib > Date: Mon Oct 22 17:50:54 2012 > New Revision: 241896 > URL: http://svn.freebsd.org/changeset/base/241896 > > Log: > Remove the support for using non-mpsafe filesystem modules. > > In particular, do not lock Giant conditionally when calling into the > filesystem module, remove the VFS_LOCK_GIANT() and related > macros. Stop handling buffers belonging to non-mpsafe filesystems. > > The VFS_VERSION is bumped to indicate the interface change which does > not result in the interface signatures changes. > > Conducted and reviewed by: attilio > Tested by: pho > Sorry for late reply. % --- head/sys/sys/namei.h 2011/12/29 12:28:05 228952 % +++ head/sys/sys/namei.h 2012/10/22 17:50:54 241896 % @@ -144,15 +144,11 @@ % #define ISOPEN 0x00200000 /* caller is opening; return a real vnode. */ % #define NOCROSSMOUNT 0x00400000 /* do not cross mount points */ % #define NOMACCHECK 0x00800000 /* do not perform MAC checks */ % -#define MPSAFE 0x01000000 /* namei() must acquire Giant if needed. */ It seems that removing the definition of MPSAFE causes out-of-tree filesystem modules to not build. Perhaps a definition can remain for some period to allow a smoother transition? Conditional on __FreeBSD_Version is the proper fix, of course, but takes longer to get everywhere. -Ben Kaduk % -#define GIANTHELD 0x02000000 /* namei() is holding giant. */ % #define AUDITVNODE1 0x04000000 /* audit the looked up vnode information */ % #define AUDITVNODE2 0x08000000 /* audit the looked up vnode information */ % #define TRAILINGSLASH 0x10000000 /* path ended in a slash */ % #define PARAMASK 0x1ffffe00 /* mask of parameter descriptors */ % % -#define NDHASGIANT(NDP) (((NDP)->ni_cnd.cn_flags & GIANTHELD) != 0) % - % /* % * Initialization of a nameidata structure. % */