Date: Thu, 17 Sep 2015 08:12:07 -0600 From: Warner Losh <imp@bsdimp.com> To: Hans Petter Selasky <hps@selasky.org> Cc: David Chisnall <theraven@freebsd.org>, Gleb Smirnoff <glebius@freebsd.org>, src-committers <src-committers@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org> Subject: Re: svn commit: r287780 - in head: share/man/man9 sys/kern sys/sys Message-ID: <CANCZdfoaW1QcHL7dpcNERz5es=-rAqtsE7u%2BZs0_Qxbi0JVLNQ@mail.gmail.com> In-Reply-To: <55FA8A3F.4000005@selasky.org> References: <201509141052.t8EAqRWf008293@repo.freebsd.org> <20150916220559.GS1023@FreeBSD.org> <55FA69BD.10507@selasky.org> <0952027A-5276-487D-99B8-74747B0EEF5D@FreeBSD.org> <55FA8A3F.4000005@selasky.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi Hans, Given how contentious this has been in the past, perhaps it would be better to goad people like rrs@ into giving you a positive, explicit OK rather than relying on a timeout that may not indicate that your change is good, just that your reviewers are busy. Warner On Thu, Sep 17, 2015 at 3:39 AM, Hans Petter Selasky <hps@selasky.org> wrote: > On 09/17/15 11:07, David Chisnall wrote: > >> On 17 Sep 2015, at 08:20, Hans Petter Selasky <hps@selasky.org> wrote: >> >>> >>> On 09/17/15 00:05, Gleb Smirnoff wrote: >>> >>>> Weren't you explicitly asked not to touch this system without a proper >>>> review and discussion? >>>> >>> >>> Adding a new function is not touching code. >>> >> >> Adding a new interface to an existing core subsystem is most definitely >> touching the system. I would expect *anyone* making a change like this t= o >> have both the design and code reviewed for sanity checking. >> > > For someone who has already been required to have explicit review of an= y > changes to the subsystem to skip this step shows a flagrant disregard for > the project=E2=80=99s policies and best practices. > > David, > > My patch is _not_ touching the existing callout system. It's touching the > callout API. Maybe my understanding of touching is different than yours. > You can voice your conserns in phabricator please, isn't that why we have > Phabricator? > > https://reviews.freebsd.org/D3521 > > The differential review has been out for 14 days with relevant people lik= e > rss on the reviewers list, and no conserns were raised. Only manual page > comments from wblock, and those were addressed. I will refer to a well > known saying, that whoever tier agree. It is a bit late to shout now. > > David, I think phabricator allows filtering so that all commits which > touch sys/kern gets your subscription. At least wblock was automatically > subscribed because of updating some manual pages. I think that's the way = to > go. > > Let's end this discussion here and move it somewhere else. > > --HPS > > >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfoaW1QcHL7dpcNERz5es=-rAqtsE7u%2BZs0_Qxbi0JVLNQ>