From owner-svn-src-head@FreeBSD.ORG Fri Oct 22 20:13:59 2010 Return-Path: Delivered-To: svn-src-head@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 52D9E1065703; Fri, 22 Oct 2010 20:13:59 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (bsdimp.com [199.45.160.85]) by mx1.freebsd.org (Postfix) with ESMTP id EECA98FC14; Fri, 22 Oct 2010 20:13:58 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by harmony.bsdimp.com (8.14.3/8.14.1) with ESMTP id o9MK38gG060604; Fri, 22 Oct 2010 14:03:08 -0600 (MDT) (envelope-from imp@bsdimp.com) Date: Fri, 22 Oct 2010 14:03:08 -0600 (MDT) Message-Id: <20101022.140308.487226281.imp@bsdimp.com> To: dim@FreeBSD.org From: Warner Losh In-Reply-To: <4CC1EBEB.2020309@FreeBSD.org> References: <201010221807.o9MI7LD8061657@svn.freebsd.org> <20101022.124640.74690513.imp@bsdimp.com> <4CC1EBEB.2020309@FreeBSD.org> X-Mailer: Mew version 6.3 on Emacs 23.2 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: svn-src-head@FreeBSD.org, rdivacky@FreeBSD.org, src-committers@FreeBSD.org, svn-src-all@FreeBSD.org Subject: Re: svn commit: r214210 - head/sys/boot/i386/boot2 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Oct 2010 20:13:59 -0000 In message: <4CC1EBEB.2020309@FreeBSD.org> Dimitry Andric writes: : On 2010-10-22 20:46, Warner Losh wrote: : >> Avoid using memcpy() for copying 32bit chunks. This shrinks : >> the resulting code a little. : > : > I think I put the memcpy code in when I was porting to ARM to reduce : > the diffs since it is needed there... : Due to alignment problems otherwise? Yes. At the time it didn't make a difference to the size of boot2. Now I know that we're looking for every byte to trim... Warner