From owner-svn-src-all@freebsd.org Wed Jan 15 19:10:25 2020 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 6DD821FA4A3; Wed, 15 Jan 2020 19:10:25 +0000 (UTC) (envelope-from nwhitehorn@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 47ycNK22frz3MyB; Wed, 15 Jan 2020 19:10:25 +0000 (UTC) (envelope-from nwhitehorn@freebsd.org) Received: from comporellon.tachypleus.net (unknown [IPv6:2605:e000:1314:5ea:e009:631a:49f0:142c]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) (Authenticated sender: nwhitehorn/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 9E06618F78; Wed, 15 Jan 2020 19:10:24 +0000 (UTC) (envelope-from nwhitehorn@freebsd.org) Subject: Re: svn commit: r356758 - in head/usr.sbin/bsdinstall: . scripts To: Oliver Pinter , Ben Woods Cc: "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" , Ed Maste References: <202001150747.00F7lqiG071097@repo.freebsd.org> From: Nathan Whitehorn Message-ID: Date: Wed, 15 Jan 2020 11:10:21 -0800 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Language: en-US X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Jan 2020 19:10:25 -0000 I agree -- this seems like a really big change, especially with no discussion. -Nathan On 2020-01-15 10:57, Oliver Pinter wrote: > > > On Wednesday, January 15, 2020, Ben Woods > wrote: > > Author: woodsb02 (ports committer) > Date: Wed Jan 15 07:47:52 2020 > New Revision: 356758 > URL: https://svnweb.freebsd.org/changeset/base/356758 > > > Log: >   bsdinstall: Change "default" (first) Partitioning method to ZFS > >   Reported by:  Ruben Schade (during his talk at linux.conf.au > ) >   Approved by:  philip >   Differential Revision:        https://reviews.freebsd.org/D23173 > > > > What's the justification behind this change?  > Plus I miss from here the relontes tag.  > >   > > > Modified: >   head/usr.sbin/bsdinstall/bsdinstall.8 >   head/usr.sbin/bsdinstall/scripts/auto > > Modified: head/usr.sbin/bsdinstall/bsdinstall.8 > ============================================================================== > --- head/usr.sbin/bsdinstall/bsdinstall.8       Wed Jan 15 > 06:18:32 2020        (r356757) > +++ head/usr.sbin/bsdinstall/bsdinstall.8       Wed Jan 15 > 07:47:52 2020        (r356758) > @@ -119,7 +119,7 @@ Provides the installer's interactive guided > disk parti >  installations. >  Defaults to UFS. >  .It Cm zfsboot > -Provides an alternative ZFS-only automatic interactive disk > partitioner. > +Provides a ZFS-only automatic interactive disk partitioner. >  Creates a single >  .Ic zpool >  with separate datasets for > > Modified: head/usr.sbin/bsdinstall/scripts/auto > ============================================================================== > --- head/usr.sbin/bsdinstall/scripts/auto       Wed Jan 15 > 06:18:32 2020        (r356757) > +++ head/usr.sbin/bsdinstall/scripts/auto       Wed Jan 15 > 07:47:52 2020        (r356758) > @@ -289,7 +289,7 @@ Shell \"Open a shell and partition by hand\"" >  CURARCH=$( uname -m ) >  case $CURARCH in >         amd64|arm64|i386)       # Booting ZFS Supported > -               PMODES="$PMODES \"Auto (ZFS)\" \"Guided Root-on-ZFS\"" > +               PMODES="\"Auto (ZFS)\" \"Guided Root-on-ZFS\" $PMODES" >                 ;; >         *)              # Booting ZFS Unspported >                 ;; > @@ -303,6 +303,10 @@ PARTMODE=`echo $PMODES | xargs dialog > --backtitle "Fre >  exec 3>&- > >  case "$PARTMODE" in > +"Auto (ZFS)")  # ZFS > +       bsdinstall zfsboot || error "ZFS setup failed" > +       bsdinstall mount || error "Failed to mount filesystem" > +       ;; >  "Auto (UFS)")  # Guided >         bsdinstall autopart || error "Partitioning error" >         bsdinstall mount || error "Failed to mount filesystem" > @@ -319,10 +323,6 @@ case "$PARTMODE" in >         else >                 bsdinstall partedit || error "Partitioning error" >         fi > -       bsdinstall mount || error "Failed to mount filesystem" > -       ;; > -"Auto (ZFS)")  # ZFS > -       bsdinstall zfsboot || error "ZFS setup failed" >         bsdinstall mount || error "Failed to mount filesystem" >         ;; >  *) > _______________________________________________ > svn-src-head@freebsd.org  mailing > list > https://lists.freebsd.org/mailman/listinfo/svn-src-head > > To unsubscribe, send any mail to > "svn-src-head-unsubscribe@freebsd.org > " >