From owner-freebsd-commit Mon Oct 16 15:33:43 1995 Return-Path: owner-commit Received: (from root@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id PAA25963 for freebsd-commit-outgoing; Mon, 16 Oct 1995 15:33:43 -0700 Received: (from root@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id PAA25903 for cvs-all-outgoing; Mon, 16 Oct 1995 15:32:18 -0700 Received: (from root@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id PAA25891 for cvs-sys-outgoing; Mon, 16 Oct 1995 15:32:16 -0700 Received: from irz301.inf.tu-dresden.de (irz301.inf.tu-dresden.de [141.76.1.11]) by freefall.freebsd.org (8.6.12/8.6.6) with ESMTP id PAA25864 ; Mon, 16 Oct 1995 15:32:01 -0700 Received: from sax.sax.de by irz301.inf.tu-dresden.de (8.6.12/8.6.12-s1) with ESMTP id XAA16665; Mon, 16 Oct 1995 23:09:46 +0100 Received: by sax.sax.de (8.6.11/8.6.12-s1) with UUCP id XAA23353; Mon, 16 Oct 1995 23:09:46 +0100 Received: (from j@localhost) by uriah.heep.sax.de (8.6.12/8.6.9) id XAA27001; Mon, 16 Oct 1995 23:09:04 +0100 From: J Wunsch Message-Id: <199510162209.XAA27001@uriah.heep.sax.de> Subject: Re: cvs commit: src/sys/net route.c To: wollman@freefall.freebsd.org (Garrett A. Wollman) Date: Mon, 16 Oct 1995 23:09:03 +0100 (MET) Cc: CVS-commiters@freefall.freebsd.org, cvs-sys@freefall.freebsd.org Reply-To: joerg_wunsch@uriah.heep.sax.de (Joerg Wunsch) In-Reply-To: <199510161909.MAA17617@freefall.freebsd.org> from "Garrett A. Wollman" at Oct 16, 95 12:09:44 pm X-Phone: +49-351-2012 669 X-Mailer: ELM [version 2.4 PL23] MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8bit Content-Length: 865 Sender: owner-commit@FreeBSD.org Precedence: bulk As Garrett A. Wollman wrote: > > wollman 95/10/16 12:09:43 > > Modified: sys/net route.c > Log: > When adding a route fails because there is already a route with the same > (mask,value) in the tree, don't immediately return EEXIST. Instead, check > to see if the pre-existing route was generated by protcol-cloning. If so, > then it is OK to simply blow away the old route and re-attempt the insertion. > If not, then fall back to the same error code as before. > Is there a chance to get this one into 2.1, David? I'm more than willing to apply this fix to our ISP's machine which is suffering a great pain from just this bug. This would provide for a good reality test. -- cheers, J"org joerg_wunsch@uriah.heep.sax.de -- http://www.sax.de/~joerg/ -- NIC: JW11-RIPE Never trust an operating system you don't have sources for. ;-)