From owner-dev-commits-src-main@freebsd.org Fri Mar 12 18:14:10 2021 Return-Path: Delivered-To: dev-commits-src-main@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id BA4AF5A8B1F for ; Fri, 12 Mar 2021 18:14:10 +0000 (UTC) (envelope-from jamie@freebsd.org) Received: from gritton.org (gritton.org [199.192.165.131]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4Dxv8f4BkQz4fpY for ; Fri, 12 Mar 2021 18:14:10 +0000 (UTC) (envelope-from jamie@freebsd.org) Received: from gritton.org ([127.0.0.131]) (authenticated bits=0) by gritton.org (8.15.2/8.15.2) with ESMTPA id 12CIE2We068057; Fri, 12 Mar 2021 10:14:02 -0800 (PST) (envelope-from jamie@freebsd.org) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Date: Fri, 12 Mar 2021 10:14:02 -0800 From: James Gritton To: Harry Schmalzbauer Cc: dev-commits-src-main@freebsd.org Subject: Re: git: 6e1d1bfcac77 - main - jail: Improve locking when removing prisons In-Reply-To: <0e8ca80f-cf62-4707-7cbd-dc0bbef061ed@omnilan.de> References: <202102202242.11KMg79W017503@gitrepo.freebsd.org> <0e8ca80f-cf62-4707-7cbd-dc0bbef061ed@omnilan.de> User-Agent: Roundcube Webmail/1.4.1 Message-ID: <26d207055d570f45ba786c24855ac283@freebsd.org> X-Sender: jamie@freebsd.org X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.6.2 (gritton.org [127.0.0.131]); Fri, 12 Mar 2021 10:14:02 -0800 (PST) X-Rspamd-Queue-Id: 4Dxv8f4BkQz4fpY X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-BeenThere: dev-commits-src-main@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for the main branch of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 12 Mar 2021 18:14:10 -0000 On 2021-03-12 02:01, Harry Schmalzbauer wrote: > Am 20.02.2021 um 23:42 schrieb Jamie Gritton: >> The branch main has been updated by jamie: >> >> URL: >> https://cgit.FreeBSD.org/src/commit/?id=6e1d1bfcac77603541706807803a198c6d954d7c >> >> commit 6e1d1bfcac77603541706807803a198c6d954d7c >> Author: Jamie Gritton >> AuthorDate: 2021-02-20 22:38:58 +0000 >> Commit: Jamie Gritton >> CommitDate: 2021-02-20 22:38:58 +0000 >> >> jail: Improve locking when removing prisons >> Change the flow of prison_deref() so it doesn't let go of >> allprison_lock >> until it's completely done using it (except for a possible drop >> as part >> of an upgrade on its first try). >> Differential Revision: https://reviews.freebsd.org/D28458 >> MFC after: 3 days >> --- >> sys/kern/kern_jail.c | 69 >> +++++++++++++++++++++++++++++++--------------------- >> 1 file changed, 41 insertions(+), 28 deletions(-) > > Hello, > > do you still plan to MFC this?  It seems there's a bunch of locking > related rework not MFC yet, but this one had the MFC tag in the commit > log, so I guess it's a more important fix. Yes, still plan to, and in fact I will. I let the MFC reminder slip past me, and once 13.0 was solidified allowed it to stay slipped. I'll MFC many of the other changes as well. - Jamie