From owner-freebsd-ports-bugs@FreeBSD.ORG  Wed May 27 13:40:02 2009
Return-Path: <owner-freebsd-ports-bugs@FreeBSD.ORG>
Delivered-To: freebsd-ports-bugs@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id CAAFB106566B
	for <freebsd-ports-bugs@hub.freebsd.org>;
	Wed, 27 May 2009 13:40:02 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id B82448FC1B
	for <freebsd-ports-bugs@hub.freebsd.org>;
	Wed, 27 May 2009 13:40:02 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id n4RDe2Vf043876
	for <freebsd-ports-bugs@freefall.freebsd.org>;
	Wed, 27 May 2009 13:40:02 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.14.3/8.14.3/Submit) id n4RDe2dD043875;
	Wed, 27 May 2009 13:40:02 GMT (envelope-from gnats)
Date: Wed, 27 May 2009 13:40:02 GMT
Message-Id: <200905271340.n4RDe2dD043875@freefall.freebsd.org>
To: freebsd-ports-bugs@FreeBSD.org
From: Pavel Gorshkov <gorshkov.pavel@gmail.com>
Cc: 
Subject: Re: ports/134474: deskutils/wmpinboard segfaults on startup
X-BeenThere: freebsd-ports-bugs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: Pavel Gorshkov <gorshkov.pavel@gmail.com>
List-Id: Ports bug reports <freebsd-ports-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs>, 
	<mailto:freebsd-ports-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports-bugs>
List-Post: <mailto:freebsd-ports-bugs@freebsd.org>
List-Help: <mailto:freebsd-ports-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs>, 
	<mailto:freebsd-ports-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 27 May 2009 13:40:03 -0000

The following reply was made to PR ports/134474; it has been noted by GNATS.

From: Pavel Gorshkov <gorshkov.pavel@gmail.com>
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/134474: deskutils/wmpinboard segfaults on startup
Date: Wed, 27 May 2009 17:12:04 +0400

 --NzB8fVQJ5HfG6fxh
 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: inline
 
 Fixed.  XCreateIC() was getting 4 zero bytes + 4 extra bytes of
 garbage instead of the NULL pointer needed to terminate the va_list.
 
 --NzB8fVQJ5HfG6fxh
 Content-Type: text/x-diff; charset=us-ascii
 Content-Disposition: attachment; filename="wmpinboard-missing-sentinel.diff"
 
 --- src/xmisc.c.orig	2009-05-27 17:03:25.000000000 +0400
 +++ src/xmisc.c	2009-05-27 16:42:40.000000000 +0400
 @@ -204,7 +204,7 @@
      return;
    }
  
 -  if (XGetIMValues(xim, XNQueryInputStyle, &xim_styles, 0) || !xim_styles) {
 +  if (XGetIMValues(xim, XNQueryInputStyle, &xim_styles, NULL) || !xim_styles) {
      XCloseIM(xim);
  #ifdef DEBUG_IC
      fprintf(stderr, "Input method doesn't support any style.\n");
 @@ -258,7 +258,7 @@
    }
  
    InputContext = XCreateIC(xim, XNInputStyle, input_style,
 -    XNClientWindow, win, XNFocusWindow, win, 0);
 +    XNClientWindow, win, XNFocusWindow, win, NULL);
  
    if (!InputContext) {
      XCloseIM(xim);
 
 --NzB8fVQJ5HfG6fxh--