From owner-freebsd-gecko@FreeBSD.ORG Mon Aug 17 17:21:12 2009 Return-Path: Delivered-To: gecko@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id BFECE10656A5 for ; Mon, 17 Aug 2009 17:21:12 +0000 (UTC) (envelope-from marcus@marcuscom.com) Received: from creme-brulee.marcuscom.com (marcuscom-pt.tunnel.tserv1.fmt.ipv6.he.net [IPv6:2001:470:1f00:ffff::1279]) by mx1.freebsd.org (Postfix) with ESMTP id 6F99A8FC62 for ; Mon, 17 Aug 2009 17:21:12 +0000 (UTC) Received: from [IPv6:2001:470:1f00:2464::4] (shumai.marcuscom.com [IPv6:2001:470:1f00:2464::4]) by creme-brulee.marcuscom.com (8.14.3/8.14.3) with ESMTP id n7HHLj8f063692; Mon, 17 Aug 2009 13:21:46 -0400 (EDT) (envelope-from marcus@marcuscom.com) From: Joe Marcus Clarke To: Andreas Tobler In-Reply-To: <4A87F50A.7000802@fgznet.ch> References: <4A7F1AB0.9040605@fgznet.ch> <4A807B1B.20605@fgznet.ch> <1250359762.23396.28.camel@shumai.marcuscom.com> <4A87F387.507@fgznet.ch> <4A87F50A.7000802@fgznet.ch> Content-Type: multipart/signed; micalg="pgp-sha1"; protocol="application/pgp-signature"; boundary="=-VGZ8mO7ETNYuJqlRedAe" Organization: MarcusCom, Inc. Date: Mon, 17 Aug 2009 13:20:51 -0400 Message-Id: <1250529651.23396.63.camel@shumai.marcuscom.com> Mime-Version: 1.0 X-Mailer: Evolution 2.26.3 FreeBSD GNOME Team Port X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,NO_RELAYS autolearn=ham version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on creme-brulee.marcuscom.com Cc: gecko@freebsd.org Subject: Re: firefox3 under powerpc not building X-BeenThere: freebsd-gecko@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Gecko Rendering Engine issues List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Aug 2009 17:21:12 -0000 --=-VGZ8mO7ETNYuJqlRedAe Content-Type: text/plain Content-Transfer-Encoding: quoted-printable On Sun, 2009-08-16 at 14:01 +0200, Andreas Tobler wrote: > Andreas Tobler wrote: > > Joe Marcus Clarke wrote: > >> On Mon, 2009-08-10 at 21:55 +0200, Andreas Tobler wrote: > >>> Hi again, > >>> > >>> replying to myself. > >>> > >>> > >>> Andreas Tobler wrote: > >>> > >>>> I can not build firefox3 (3.0.13 and up) under FreeBSD -CURRENT. As = far=20 > >>>> as I tracked down it is an issue in the firefox sources itself. > >>>> > >>>> The last working build I had was 3.0.10. > >>>> > >>>> Here in this area it breaks: > >>>> > >>>> http://mxr.mozilla.org/mozilla1.9.1/diff?file=3D/security/nss/lib/fr= eebl/Makefile&diffvar=3Dmozilla1.8.0 > >>>> > >>>> The below snippet does somehow not work. > >>>> ----- > >>>> # some code wants _X86_ defined for intel CPUs. > >>>> # coreconf does this for windows, but not for Linux, FreeBSD, etc. > >>>> ifeq (,$(filter-out x86 x86_64,$(CPU_ARCH))) > >>>> ifneq (,$(filter-out WIN%,$(OS_TARGET))) > >>>> DEFINES +=3D -D_X86_ > >>>> endif > >>>> endif > >>>> ----- > >>> It does not work on powerpc since the CPU_ARCH is set to x86 in=20 > >>> security/coreconf/FreeBSD.mk, gah! > >>> > >>>> On powerpc I get the -D_X86_ passed to the compile options, very bad= .=20 > >>>> But I do not understand why. Might be that the first filter-out does= not=20 > >>>> work as expected? > >>>> > >>>> I compared with an x86 build and with an x86_64 build. On the x86 it= =20 > >>>> works as expected. But also under der x86_64 it does not do what I=20 > >>>> expect. Under x86_64 I'd expect the -D_X86_ in the compile options, = right? > >>> The x86_64 case is also clear now, the CPU_ARCH is set to amd64, so t= he=20 > >>> -D_X86_ is not set. We might need a patch to=20 > >>> security/nss/lib/freebl/Makefile which also includes the amd64 to the= =20 > >>> first filter-out above? Like this one: > >> Thanks for these patches. Can you resend them as attachments (or post > >> them) so they can be easily extracted? > >=20 > > Here it is, the powerpc one. It is against 3.0.13 source base. The amd6= 4=20 > > I did not follow up since it does build, with or without -D_X86_ on amd= 64. >=20 > Forget the previous post, here is the working one. A missing endif.... Thanks, I added this to the security/nss port (well, part of it). Joe --=20 PGP Key : http://www.marcuscom.com/pgp.asc --=-VGZ8mO7ETNYuJqlRedAe Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (FreeBSD) iEYEABECAAYFAkqJkXEACgkQb2iPiv4Uz4fdSACffAhFIbwtDI1eaxe36r+xZt/r GJgAnRSWjBb5ggv4b3vKSoOK1vsTHvDr =0bUd -----END PGP SIGNATURE----- --=-VGZ8mO7ETNYuJqlRedAe--