From owner-freebsd-bugs@FreeBSD.ORG Tue Feb 26 02:20:04 2008 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id DCEE416A401 for ; Tue, 26 Feb 2008 02:20:04 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id CA7B913C47E for ; Tue, 26 Feb 2008 02:20:04 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.2/8.14.2) with ESMTP id m1Q2K4YS011122 for ; Tue, 26 Feb 2008 02:20:04 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.2/8.14.1/Submit) id m1Q2K4dZ011121; Tue, 26 Feb 2008 02:20:04 GMT (envelope-from gnats) Date: Tue, 26 Feb 2008 02:20:04 GMT Message-Id: <200802260220.m1Q2K4dZ011121@freefall.freebsd.org> To: freebsd-bugs@FreeBSD.org From: Volker Cc: Subject: Re: misc/121093: pkg_add(1) does nothing and returns zero if called without arguments X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Volker List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 Feb 2008 02:20:04 -0000 The following reply was made to PR misc/121093; it has been noted by GNATS. From: Volker To: bug-followup@FreeBSD.org, jtsn@gmx.de Cc: Subject: Re: misc/121093: pkg_add(1) does nothing and returns zero if called without arguments Date: Tue, 26 Feb 2008 03:09:23 +0100 This is a multi-part message in MIME format. --------------090208000807030901070300 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Hi Joseph, using the attached patch, `pkg_add' now gives: pkg_add: missing package name(s) usage: pkg_add [-vInfFrRMSK] [-t template] [-p prefix] [-P prefix] [-C chrootdir] pkg-name [pkg-name ...] which I think should be correct behavior. The patch may be a few lines off but should otherwise apply cleanly. --------------090208000807030901070300 Content-Type: text/x-patch; name="pkg_add.diff" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="pkg_add.diff" --- usr.sbin/pkg_install/add/main.c.orig 2008-02-26 03:02:35.000000000 +0100 +++ usr.sbin/pkg_install/add/main.c 2008-02-26 03:02:48.000000000 +0100 @@ -238,7 +238,7 @@ } } /* If no packages, yelp */ - else if (!ch) { + if (!ch) { warnx("missing package name(s)"); usage(); } --------------090208000807030901070300--