From owner-svn-src-all@freebsd.org Tue Jan 23 19:13:52 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id ADD9BEC1408; Tue, 23 Jan 2018 19:13:52 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: from mail-io0-f179.google.com (mail-io0-f179.google.com [209.85.223.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 7D68B6A3B1; Tue, 23 Jan 2018 19:13:52 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: by mail-io0-f179.google.com with SMTP id l17so2095550ioc.3; Tue, 23 Jan 2018 11:13:52 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:reply-to:in-reply-to:references :from:date:message-id:subject:to:cc; bh=hkoez4e0bTy745O9yjMCNdByiMHgFTk8pV8M2LCE/Yk=; b=nKZdEa4hg9pl4f5Z1PAzhceGXohWErqNu/pr3FEOjvSR0u7L2A2AtevR2lcG7JHtlL I3ZG8EWsGqaM0TCKJJdusIDe/xmg5A7cr1f+06vrPd43q3Qk+cjGc7D2tCkyIto1Z6X3 1Eaia+ukbHm6l22y7OGc+aWCIidefuDNZpHrYSj4elT8BctaTLnzNYeWpk+4GrZX3ACx e3meUr5O2RKVqkzEblDEMnVvX+S4Hp6YZFgf2rTqIRCr7e9KXutG8ZaGid26fLWdNlji bCbMnbhabm+GU+Vk0jeRl9tIU6M/REnhzdXKeUe24l3PkG/P5Ewg/HQzr++Gi19AhYe4 1kIw== X-Gm-Message-State: AKwxytex6aF8+qy4xaqOwjAayOs5Xo++E+naMoplbSB3LS4khYb3Bbpe WqFGiPmn4YNXZY7vqT3QZlhAtLIM X-Google-Smtp-Source: AH8x227uaYedowGXQ311tAnLKJqqgyrgNDYauhfXL+vhgllzsva5vWxqowSTHUtMtBIJV1CB1ZVU7g== X-Received: by 10.107.154.129 with SMTP id c123mr5210526ioe.203.1516734516798; Tue, 23 Jan 2018 11:08:36 -0800 (PST) Received: from mail-io0-f182.google.com (mail-io0-f182.google.com. [209.85.223.182]) by smtp.gmail.com with ESMTPSA id 188sm9684341iou.80.2018.01.23.11.08.36 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 23 Jan 2018 11:08:36 -0800 (PST) Received: by mail-io0-f182.google.com with SMTP id b198so2073340iof.6; Tue, 23 Jan 2018 11:08:36 -0800 (PST) X-Received: by 10.107.174.196 with SMTP id n65mr5158112ioo.256.1516734516352; Tue, 23 Jan 2018 11:08:36 -0800 (PST) MIME-Version: 1.0 Reply-To: cem@freebsd.org Received: by 10.2.95.152 with HTTP; Tue, 23 Jan 2018 11:08:35 -0800 (PST) In-Reply-To: <201801211542.w0LFgbsp005980@repo.freebsd.org> References: <201801211542.w0LFgbsp005980@repo.freebsd.org> From: Conrad Meyer Date: Tue, 23 Jan 2018 11:08:35 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r328218 - in head/sys: amd64/amd64 arm/xscale/ixp425 arm64/arm64 cam cam/ctl compat/ndis dev/aacraid dev/advansys dev/ath dev/beri/virtio dev/bnxt dev/bwn dev/ciss dev/cxgbe/crypto dev/... To: "Pedro F. Giffuni" Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 23 Jan 2018 19:13:52 -0000 Hi Pedro, On Sun, Jan 21, 2018 at 7:42 AM, Pedro F. Giffuni wrote: > Author: pfg > Date: Sun Jan 21 15:42:36 2018 > New Revision: 328218 > URL: https://svnweb.freebsd.org/changeset/base/328218 > > Log: > Revert r327828, r327949, r327953, r328016-r328026, r328041: > Uses of mallocarray(9). > > The use of mallocarray(9) has rocketed the required swap to build FreeBSD. > This is likely caused by the allocation size attributes which put extra pressure > on the compiler. I'm confused about this change. Wouldn't it be better to remove the annotation/attributes from mallocarray() than to remove the protection against overflow? (If the compiler is fixed in the future to not use excessive memory with these attributes, they can be conditionalized on compiler version, of course.) Best, Conrad