From owner-cvs-all@FreeBSD.ORG Mon Feb 14 16:19:34 2005 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id CEBB616A4CF; Mon, 14 Feb 2005 16:19:32 +0000 (GMT) Received: from cheer.mahoroba.org (gw4.mahoroba.org [218.45.22.175]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4DBCA43D45; Mon, 14 Feb 2005 16:19:32 +0000 (GMT) (envelope-from ume@mahoroba.org) Received: from lyrics.mahoroba.org (ume@lyrics.mahoroba.org [IPv6:3ffe:501:185b:8010:280:88ff:fe03:4841]) (user=ume mech=CRAM-MD5 bits=0)j1EGJLHJ009789 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 15 Feb 2005 01:19:21 +0900 (JST) (envelope-from ume@mahoroba.org) Date: Tue, 15 Feb 2005 01:19:20 +0900 Message-ID: From: Hajimu UMEMOTO To: Alexey Zelkin In-Reply-To: <20050214160838.GA1414@phantom.cris.net> References: <200502141133.j1EBXC6D001449@repoman.freebsd.org> <20050214160838.GA1414@phantom.cris.net> User-Agent: xcite1.38> Wanderlust/2.13.1 (You Oughta Know) SEMI/1.14.6 (Maruoka) FLIM/1.14.7 (=?ISO-8859-4?Q?Sanj=F2?=) APEL/10.6 Emacs/21.3.50 (i386-unknown-freebsd5.3) MULE/5.0 (SAKAKI) X-Operating-System: FreeBSD 5.3-RELEASE-p3 MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII X-Virus-Scanned: by amavisd-new X-Virus-Status: Clean X-Spam-Status: No, score=-5.6 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.0.2 X-Spam-Checker-Version: SpamAssassin 3.0.2 (2004-11-16) on cheer.mahoroba.org cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/include netdb.h src/lib/libc/net getaddrinfo.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 Feb 2005 16:19:34 -0000 Hi, >>>>> On Mon, 14 Feb 2005 18:08:38 +0200 >>>>> Alexey Zelkin said: phantom> 1. This is optimization. Optimization for what? It is called at only error. phantom> 2. This is preparation to addition of NLS support for gai_strerror() Oh, it fine. However, I don't imagine why we need your previous change for NLS support. phantom> Actually, since gai_strerror() is exported function and only user phantom> of ai_errlist[], would not it be better to move these to separate phantom> source file ? It will make KAME integration for getaddrinfo.c phantom> much easier, IMHO. No, we were torn by EAI_* around RFC 2553 and RFC 3493. So, I don't want having difference against KAME here. Actually, your change is backward. See http://www.kame.net/dev/cvsweb2.cgi/kame/kame/kame/libinet6/getaddrinfo.c#rev1.102 Sincerely, -- Hajimu UMEMOTO @ Internet Mutual Aid Society Yokohama, Japan ume@mahoroba.org ume@{,jp.}FreeBSD.org http://www.imasy.org/~ume/