From owner-svn-src-all@FreeBSD.ORG Sat Dec 18 20:17:28 2010 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A7387106566B; Sat, 18 Dec 2010 20:17:28 +0000 (UTC) (envelope-from onemda@gmail.com) Received: from mail-qw0-f54.google.com (mail-qw0-f54.google.com [209.85.216.54]) by mx1.freebsd.org (Postfix) with ESMTP id B0CB38FC13; Sat, 18 Dec 2010 20:17:27 +0000 (UTC) Received: by qwj9 with SMTP id 9so1637919qwj.13 for ; Sat, 18 Dec 2010 12:17:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:received:in-reply-to :references:date:message-id:subject:from:to:cc:content-type; bh=/ssGQAB/MsiO95gu8wrEdPc8OvzmdFLC0MNzbqbaLzc=; b=sg7yt1TROaZPp0Y2tn6qSOyZzXo13Iu7JH2VUIWrbhXi9IRw9Fd1mhbvqyAUkxhZRB 604wZJq+ol3ak8DZH2Rj5YupGXGYwZWWGHx1hap1eMvHeFajsUsNPoYGdbfLXty2ivgY oTUGM+IQZKlr0WPwg5uBbN1YhicScbaNEw67k= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; b=XvEjJiiztPmw8GuEklYaUylK+2srVyzC+aI2uatdWj/+Gnmzy4vHyw4XeGxaDXrjF1 fvh1jG20ZejDH5DCe0Cpbmy31HPgWkvsggmLnS311m7gsrxikzP4aNf+7XbxVtb0U9cY 8jDqx1MRUlJymw2SSCvdFNs3rznUr6rO7uVrI= MIME-Version: 1.0 Received: by 10.229.189.72 with SMTP id dd8mr2233325qcb.18.1292703445838; Sat, 18 Dec 2010 12:17:25 -0800 (PST) Received: by 10.220.175.141 with HTTP; Sat, 18 Dec 2010 12:17:25 -0800 (PST) In-Reply-To: <201012182048.54969.tijl@freebsd.org> References: <201012181421.oBIELTSd093635@svn.freebsd.org> <201012182048.54969.tijl@freebsd.org> Date: Sat, 18 Dec 2010 20:17:25 +0000 Message-ID: From: Paul B Mahol To: Tijl Coosemans Content-Type: text/plain; charset=ISO-8859-1 Cc: svn-src-head@freebsd.org, Kostik Belousov , svn-src-all@freebsd.org, src-committers@freebsd.org, John Baldwin Subject: Re: svn commit: r216518 - in head/sys/dev: if_ndis le malo sound/pci X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 18 Dec 2010 20:17:28 -0000 On 12/18/10, Tijl Coosemans wrote: > On Saturday 18 December 2010 19:41:13 Paul B Mahol wrote: >> On 12/18/10, Tijl Coosemans wrote: >>> Author: tijl >>> Date: Sat Dec 18 14:21:28 2010 >>> New Revision: 216518 >>> URL: http://svn.freebsd.org/changeset/base/216518 >>> >>> Log: >>> Use convenience functions where possible instead of accessing the PCI >>> configuration registers directly. >>> >>> Remove pci_enable_io calls where they are redundant. The PCI bus driver >>> will set the right bits when the corresponding bus resource is >>> activated. >>> >>> Remove redundant pci_* function calls from suspend/resume methods. The >>> bus driver already saves and restores the PCI configuration. >>> >>> Reviewed by: jhb >>> Approved by: kib (mentor) >> >> Please revert change to if_ndis regarding introduction of >> pci_get_subvendor(). >> >> You compare 16bit value with 32bit value - this will always fail. > > Apologies. Instead of reverting, would the attached patch work for you? > It moves the function calls out of the while loop and makes it more clear > what subsys means. Looks fine.