From owner-freebsd-threads@FreeBSD.ORG Thu Oct 28 23:21:08 2004 Return-Path: Delivered-To: freebsd-threads@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A597016A4CE; Thu, 28 Oct 2004 23:21:08 +0000 (GMT) Received: from mail.vicor-nb.com (bigwoop.vicor-nb.com [208.206.78.2]) by mx1.FreeBSD.org (Postfix) with ESMTP id 86EBA43D53; Thu, 28 Oct 2004 23:21:08 +0000 (GMT) (envelope-from julian@elischer.org) Received: from elischer.org (julian.vicor-nb.com [208.206.78.97]) by mail.vicor-nb.com (Postfix) with ESMTP id 628327A424; Thu, 28 Oct 2004 16:21:08 -0700 (PDT) Message-ID: <41817EE4.9080302@elischer.org> Date: Thu, 28 Oct 2004 16:21:08 -0700 From: Julian Elischer User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.3.1) Gecko/20030516 X-Accept-Language: en, hu MIME-Version: 1.0 To: Daniel Eischen References: In-Reply-To: Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit cc: threads@freebsd.org cc: re@freebsd.org cc: David Xu cc: John Baldwin Subject: MFC req for 5.x/5.3 X-BeenThere: freebsd-threads@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Threading on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 Oct 2004 23:21:08 -0000 Daniel Eischen wrote: >On Thu, 28 Oct 2004, Julian Elischer wrote: > > > >>David Xu wrote: >> >> >> >>>Here is the cvs log: >>> >>>Revision Changes Path >>> 1.58 +1 -0 src/lib/libpthread/thread/thr_create.c >>> 1.14 +1 -1 src/lib/libpthread/thread/thr_find_thread.c >>> 1.115 +27 -10 src/lib/libpthread/thread/thr_kern.c >>> 1.119 +15 -11 src/lib/libpthread/thread/thr_private.h >>> 1.81 +1 -2 src/lib/libpthread/thread/thr_sig.c >>> >>> >>commit message was: >>1. Move thread list flags into new separate member, and atomically >> put DEAD thread on GC list, this closes a race between pthread_join >> and thr_cleanup. >>2. Introduce a mutex to protect tcb initialization, tls allocation and >> deallocation code in rtld seems no lock protection or it is broken, >> under stress testing, memory is corrupted. >> >> >>translates to: >> [diff removed] >> >> > >Yes, these look right. > > >