From owner-freebsd-bugs Mon Sep 11 6:50: 5 2000 Delivered-To: freebsd-bugs@freebsd.org Received: from freefall.freebsd.org (freefall.FreeBSD.org [216.136.204.21]) by hub.freebsd.org (Postfix) with ESMTP id 437B437B423 for ; Mon, 11 Sep 2000 06:50:02 -0700 (PDT) Received: (from gnats@localhost) by freefall.freebsd.org (8.9.3/8.9.2) id GAA71527; Mon, 11 Sep 2000 06:50:02 -0700 (PDT) (envelope-from gnats@FreeBSD.org) Date: Mon, 11 Sep 2000 06:50:02 -0700 (PDT) Message-Id: <200009111350.GAA71527@freefall.freebsd.org> To: freebsd-bugs@FreeBSD.org Cc: From: csg@waterspout.com (C. Stephen Gunn) Subject: Re: bin/21178: voltag selector, and unload support for chio(1) Reply-To: csg@waterspout.com (C. Stephen Gunn) Sender: owner-freebsd-bugs@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.org The following reply was made to PR bin/21178; it has been noted by GNATS. From: csg@waterspout.com (C. Stephen Gunn) To: "Kenneth D. Merry" Cc: FreeBSD-gnats-submit@FreeBSD.ORG, ajk@waterspout.com, ab@eas.purdue.edu, dpm@vutar.com Subject: Re: bin/21178: voltag selector, and unload support for chio(1) Date: Mon, 11 Sep 2000 08:50:13 -0500 On Mon, 11 Sep 2000 00:56:23 CST, "Kenneth D. Merry" wrote: > Looks like a pretty good idea. > > I took a cursory glance through the patch, and noticed the 'XXX' comment > about looking through pickers and portals. Yeah. I didn't do that because of the way the ioctl() works to fetch information from the drive. I guess it's not a big deal though. Since I don't have any pickers or portals on my test drive, I'm not familiar with when a tape might be in one. ( I guess I can figure the portal one out real easy ). > I'd suggest looking at them as well, even if it won't be used very often. > (I've moved things from pickers and portals often enough, though.) I can add this. I've got some other pending comments from my homeboys on the cc: line. I'll address those as well, and submit a more recent patch early this week. > I also wonder about the 'unload' keyword. It almost sounds like something > you might use to eject a tape or something. What about calling it 'return' > instead? (I don't feel really strongly about this, but I figure we ought > to make things intuitive, if possible.) I use it exclusively to "unload" a tape from the drive to the slot that it came from. In my cursory investigation, drives (and perhaps pickers/portals) are the only changer elements with a valid source parameter. > Anyway, I'll try to give the patch a more thorough look-over in the next > few days. I won't be able to do more than that before committing it, > though, since I don't have a test changer anymore. (You've obviously > tested it, though, so we should be okay in that department.) Let me fixup some stuff based input, and I'll update the pr, and cc: you. Thanks! - Steve -- C. Stephen Gunn URL: http://www.waterspout.com/ WaterSpout Communications, Inc. Email: csg@waterspout.com 427 North 6th Street Phone: +1 765.742.6628 Lafayette, IN 47901 Fax: +1 765.742.0646 To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-bugs" in the body of the message