From owner-freebsd-stable@FreeBSD.ORG  Sun Feb 29 07:40:37 2004
Return-Path: <owner-freebsd-stable@FreeBSD.ORG>
Delivered-To: freebsd-stable@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 16BD416A4CE; Sun, 29 Feb 2004 07:40:37 -0800 (PST)
Received: from alogis.com (firewall.solit-ag.de [212.184.102.1])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 17B1F43D1D; Sun, 29 Feb 2004 07:40:35 -0800 (PST)
	(envelope-from Holger.Kipp@alogis.com)
Received: (from hk@localhost)
	by alogis.com (8.11.1/8.9.3) id i1TFeVU56618;
	Sun, 29 Feb 2004 16:40:31 +0100 (CET)
	(envelope-from hk)
Date: Sun, 29 Feb 2004 16:40:31 +0100
From: Holger Kipp <Holger.Kipp@alogis.com>
To: alexander.pohoyda@gmx.net
Message-ID: <20040229164031.A56175@intserv.int1.b.intern>
References: <Pine.BSF.4.21.0402271745150.23658-100000@InterJet.elischer.org>
	<20040229141720.GA447@tuatara.fishballoon.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-Mailer: Mutt 1.0.1i
In-Reply-To: <20040229141720.GA447@tuatara.fishballoon.org>;
	from rsm@freebsd.org on Sun, Feb 29, 2004 at 02:17:20PM +0000
cc: stable@freebsd.org
cc: hackers@freebsd.org
cc: hardware@freebsd.org
Subject: USB 2.0 Hub, patch for BSD stack
X-BeenThere: freebsd-stable@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Production branch of FreeBSD source code
	<freebsd-stable.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-stable>,
	<mailto:freebsd-stable-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-stable>
List-Post: <mailto:freebsd-stable@freebsd.org>
List-Help: <mailto:freebsd-stable-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-stable>,
	<mailto:freebsd-stable-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 29 Feb 2004 15:40:37 -0000

I have an ednet. USB 2.0 Hub 4-1 which seems to be 
identicyl to the Cypress Semiconductor Slim Hub.

The latest 4.9-STABLE is still missing the patch

> > --- uhub.c.orig Fri Jul  4 20:17:50 2003
> > +++ uhub.c      Fri Jul  4 21:57:31 2003
> > @@ -185,7 +185,7 @@
> >         /* Get hub descriptor. */
> >         req.bmRequestType = UT_READ_CLASS_DEVICE;
> >         req.bRequest = UR_GET_DESCRIPTOR;
> > -       USETW(req.wValue, 0);
> > +       USETW2(req.wValue, (dev->address > 1 ? UDESC_HUB : 0), 0);
> >         USETW(req.wIndex, 0);
> >         USETW(req.wLength, USB_HUB_DESCRIPTOR_SIZE);
> >         DPRINTFN(1,("usb_init_hub: getting hub descriptor\n"));

http://lists.freebsd.org/pipermail/freebsd-hardware/2003-July/000390.html

The hub is now working on my system, even though detaching and attaching
an 8-in-1 Card Reader (USB 2: hama 46945) several times locks the system
(ie reset required).



Will this patch be MFCd any time soon or was this part just forgotten,
as the other minor patches (usbdevs.h, usbdevs_data.h) made it to
4.9-STABLE?

Regards,
Holger Kipp