From owner-freebsd-arch Thu Sep 19 14:20:24 2002 Delivered-To: freebsd-arch@freebsd.org Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 14FB037B401 for ; Thu, 19 Sep 2002 14:20:23 -0700 (PDT) Received: from storm.FreeBSD.org.uk (storm.FreeBSD.org.uk [194.242.157.42]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2AC2F43E6A for ; Thu, 19 Sep 2002 14:20:22 -0700 (PDT) (envelope-from mark@grimreaper.grondar.org) Received: from storm.FreeBSD.org.uk (uucp@localhost [127.0.0.1]) by storm.FreeBSD.org.uk (8.12.5/8.12.5) with ESMTP id g8JLKKPb051070; Thu, 19 Sep 2002 22:20:20 +0100 (BST) (envelope-from mark@grimreaper.grondar.org) Received: (from uucp@localhost) by storm.FreeBSD.org.uk (8.12.5/8.12.5/Submit) with UUCP id g8JLKKu0051069; Thu, 19 Sep 2002 22:20:20 +0100 (BST) Received: from grimreaper.grondar.org (localhost [127.0.0.1]) by grimreaper.grondar.org (8.12.6/8.12.5) with ESMTP id g8JLF57s003495; Thu, 19 Sep 2002 22:15:05 +0100 (BST) (envelope-from mark@grimreaper.grondar.org) Message-Id: <200209192115.g8JLF57s003495@grimreaper.grondar.org> To: Bruce Evans Cc: arch@FreeBSD.ORG Subject: Re: More lint work for share/mk/ (review, please) References: <20020920054221.E2677-100000@gamplex.bde.org> In-Reply-To: <20020920054221.E2677-100000@gamplex.bde.org> ; from Bruce Evans "Fri, 20 Sep 2002 06:29:10 +1000." Date: Thu, 19 Sep 2002 22:15:05 +0100 From: Mark Murray Sender: owner-freebsd-arch@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG > > NOLINT, and this is supposed to be put into individual Makefiles > > to kill copious lint output from code out of our control (like > > GNU stuff, other contrib/ code and so on). > > Wouldn't `.undef WANT_LINT' in individual Makefiles be better than > another knob? Maybe. I dunno. There is no precedent for the .undef form, whereas we have lots for the WANT_* or NO_* type of knobs. Seems yukky to do something that requires another syntax. > % - ${LINT} ${LINTFLAGS} ${CFLAGS:M-[DIU]*} ${.ALLSRC} | more 2>&1 > % + ${LINT} ${LINTFLAGS} ${CFLAGS:M-[DIU]*} ${.ALLSRC} > > I wonder what this pipeline is for. I once thought that it was to combine > stdout with stderr to work around the bug that lint prints some messages > on stderr, but it is wrong for that -- the correct way to combine stdin > with stderr is "2>&1" before any pipe. This got discussed to death last time. It is minor and mostly irrelevant; its here for consistency with another similar removal. Locally I just put it back in the .mk file as lint: ${LINT} .... ${.ALLSRC} 2>&1 | cat so I can # make lint | less I don't feel stronly enough to discuss this any further. Take it out, leave it in. Either way suits me. :-) > % -CFLAGS += -ansi -pedantic -Wbad-function-cast -Wchar-subscripts -Winline -Wnested-externs -Wredundant-decls > % +CFLAGS += -ansi -pedantic -Wbad-function-cast -Wchar-subscripts -Winline -Wnested-externs -Wredundant-decls -Wno-long-long > % . endif > % . if ${WARNS} > 1 && ${WARNS} < 5 > % # XXX Delete -Wuninitialized by default for now -- the compiler doesn't > > No thanks. This breaks gcc's warning. -ansi means C90 (-std=c89), and > this standard doesn't have long long. Of course, programs not written in > C90 can't be compiled with this warning level. Oops! Mistake. This was not intended for the LINT commit! This is strictly local. > Non-POSIX rules shouldn't be duplicated in the POSIX section. OK. Thanks! M -- o Mark Murray \_ O.\_ Warning: this .sig is umop ap!sdn To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-arch" in the body of the message