From owner-svn-src-all@freebsd.org Wed May 30 09:25:15 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 65875F7B065; Wed, 30 May 2018 09:25:15 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id C9C71787BE; Wed, 30 May 2018 09:25:14 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from tom.home (kib@localhost [127.0.0.1]) by kib.kiev.ua (8.15.2/8.15.2) with ESMTP id w4U9Oxi2028458; Wed, 30 May 2018 12:25:02 +0300 (EEST) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua w4U9Oxi2028458 Received: (from kostik@localhost) by tom.home (8.15.2/8.15.2/Submit) id w4U9OxMf028457; Wed, 30 May 2018 12:24:59 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Wed, 30 May 2018 12:24:59 +0300 From: Konstantin Belousov To: Matt Macy Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r334361 - head/usr.sbin/pmc Message-ID: <20180530092459.GP3789@kib.kiev.ua> References: <201805300006.w4U06HK3055256@repo.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201805300006.w4U06HK3055256@repo.freebsd.org> User-Agent: Mutt/1.10.0 (2018-05-17) X-Spam-Status: No, score=-2.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FREEMAIL_FROM,NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=3.4.1 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on tom.home X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 May 2018 09:25:15 -0000 On Wed, May 30, 2018 at 12:06:17AM +0000, Matt Macy wrote: > Author: mmacy > Date: Wed May 30 00:06:17 2018 > New Revision: 334361 > URL: https://svnweb.freebsd.org/changeset/base/334361 > > Log: > pmc: don't break build with format issues > > Modified: > head/usr.sbin/pmc/Makefile > > Modified: head/usr.sbin/pmc/Makefile > ============================================================================== > --- head/usr.sbin/pmc/Makefile Tue May 29 23:08:33 2018 (r334360) > +++ head/usr.sbin/pmc/Makefile Wed May 30 00:06:17 2018 (r334361) > @@ -9,4 +9,5 @@ LIBADD= kvm pmc m ncursesw pmcstat elf > > SRCS= pmc.c pmc_util.c cmd_pmc_stat.c > > +CWARNFLAGS.cmd_pmc_stat.c= -Wno-format > .include So this builds knownly broken binary instead of stopping. If I understand your troubles right, the usual solution for them is printf("%jx", (uintmax_t)trouble); used in many places around the kernel, less so in userspace.