From nobody Thu Jun 11 04:19:16 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4gbTtw2JdFz6hV5N for ; Thu, 11 Jun 2026 04:19:36 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pl1-x62a.google.com (mail-pl1-x62a.google.com [IPv6:2607:f8b0:4864:20::62a]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4gbTtw0pJzz4JYx for ; Thu, 11 Jun 2026 04:19:36 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-pl1-x62a.google.com with SMTP id d9443c01a7336-2c0c1e0b0faso51703295ad.0 for ; Wed, 10 Jun 2026 21:19:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781151568; x=1781756368; darn=freebsd.org; h=to:references:message-id:cc:date:in-reply-to:from:subject :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=1YQwuXl7kaSJTWkn28/kGoJDrO76TuT3+T4vfNv2Iwk=; b=UmxvaKrQZ3BPfM9eusSjAdPNTSSXDq7/tmbwHhpRQr1e5Pns3Dbklh44tQkeIekPI2 JL5mI3hcL045fJyN4gzWctUpH/Erni3mc+mdn1eU6v5Susnb9XVNhR8HoUudBnD0gVOE agofw9i7+hEpJfs3lpfq5FHH/9K18RZS39bxelQBmFJ6xSWa2ZPJ4lXPHl7dt4yjBCAW 3xjl7pLYKYxdAtzgo2UxChuzSAhVRVQY95yivDJrdpwuDpnCOSOjYhtFFK8LQGyylZLC NEJXFvhv7jDCsQrJy1a2Q1ExtKGLR4icPdDrXDV+t1uItZULNMvbFjcbAsX2lHn6VL3T RX0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781151568; x=1781756368; h=to:references:message-id:cc:date:in-reply-to:from:subject :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=1YQwuXl7kaSJTWkn28/kGoJDrO76TuT3+T4vfNv2Iwk=; b=X0gQemGMGx2qIJ8BeYpBw/isQUcBzLC8115hsvzDGxZUQcBw3M63FBdAoQmfpJPBUY I+RKkthVWKBQUljw0EEg2Zwl6pASl+MCkSLabE+880aOqdvEr4Yq56aAHX9PR0vofX9b G0ceVRSQdMfxaoaBCBNtZ04e7f9wftPh/qnD2JKpRUf/THdvKPc3XfkVs55U2xrMTvOS gRPN+8TOra+oj1AWuvIRtt+eXFML45hpAlZI1YlbLTJPkpkx4zpCoX2YX8kqC70kk/Lx LmTp1UJ0Jr7RKk81PyJGkjfTjyLePUBrgm3AiMl5ug0FRjk1K+6wrXaIWzbWC4NQ0Fu0 bINw== X-Forwarded-Encrypted: i=1; AFNElJ9mXEEFWltQ+RFe+V5QzlFi57QzQmvE665hS6kExncI39SHnObg2kVjFBzndKdSRH9GH6/UkMzY1EO33fuAA/W9RVtM6A==@freebsd.org X-Gm-Message-State: AOJu0YzHv30BLXQRInIGaAuE+bYhoTIix58osSUlCqu/+lmZ3FHlYKv/ N7XEXujF0wliRlBN4o0EvUlum6t+SPe2Lp/nYUUjH8/Kay9gZjMeQsGuom6Q8g== X-Gm-Gg: Acq92OG9vqoL+8UkUBY9dKCatktVsA87htCkbIfsKmlPmv7oGfU/81JCDTb5F/5c8YF Pj+L65B5I8tuvsaQVD88jO1tdUsVNUBp+BQ2lMXRzM3/3ypZK3uYaKf/j1hU31kmpGEuOZyLBmC HjC9FEoMs+p2Hgxawmct9bq7o4O6bVKGqKV3Fgx1kl0kaQuA0oOsR+nZ16uQuEbe/ZwlO3PGwCQ wHYo745qKLIbq+X0nTVpQio6zceJWZwvGwPf9t86dPyxwi1kn5rvgfJKZG/w930z2ZBMezBVyms 8WWjuX9Jsf5oA6cgjuBNwZ6GEIzM/9HrPv9eZjci9lrLC+rNTIm64F7TWF7JCifGWDAMWcuDyDK 6qeMwVti07J6E7lJ5dFE5cXTf/KCeanMczWYyM5uVOMX6SidjNEgVPcc6/zxailQ9ECtwkpj/ZF 0wtHl7X+7Tn4dkNG2Ms3mfJEXfEg15XJZEipMhPYPSKa5UdNftnjVOYc3PHQ== X-Received: by 2002:a17:902:d4d2:b0:2bf:77b2:8b2d with SMTP id d9443c01a7336-2c2f334f0b4mr10953315ad.30.1781151568479; Wed, 10 Jun 2026 21:19:28 -0700 (PDT) Received: from smtpclient.apple ([176.100.43.200]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2c164f6d389sm250780435ad.16.2026.06.10.21.19.27 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 10 Jun 2026 21:19:27 -0700 (PDT) Content-Type: multipart/signed; boundary="Apple-Mail=_C58533D5-FB50-4324-9D32-ABDEEAAA30CE"; protocol="application/pgp-signature"; micalg=pgp-sha256 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3864.600.51.1.1\)) Subject: Re: git: 925f53682469 - main - improve renice user error messages From: "Enji Cooper (yaneurabeya)" In-Reply-To: <6a295a32.3e002.31d3fa83@gitrepo.freebsd.org> Date: Wed, 10 Jun 2026 21:19:16 -0700 Cc: "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" , androvonx95 Message-Id: <16487C94-005B-4151-B6FA-BD3FEBC1A00E@gmail.com> References: <6a295a32.3e002.31d3fa83@gitrepo.freebsd.org> To: Warner Losh X-Mailer: Apple Mail (2.3864.600.51.1.1) X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US] X-Rspamd-Queue-Id: 4gbTtw0pJzz4JYx X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated --Apple-Mail=_C58533D5-FB50-4324-9D32-ABDEEAAA30CE Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On Jun 10, 2026, at 5:36=E2=80=AFAM, Warner Losh = wrote: >=20 > The branch main has been updated by imp: >=20 > URL: = https://cgit.FreeBSD.org/src/commit/?id=3D925f53682469ea12c017b48114b16e8f= 1627fb0b >=20 > commit 925f53682469ea12c017b48114b16e8f1627fb0b > Author: androvonx95 > AuthorDate: 2025-07-15 18:01:28 +0000 > Commit: Warner Losh > CommitDate: 2026-06-10 12:35:02 +0000 >=20 > improve renice user error messages >=20 > Improve error handling for invalid user names and UIDs in renice: > - Use warnx() and err() for consistent error reporting > - Set errno =3D EINVAL for invalid input > - Provide clearer error messages for invalid user names and UIDs > - Add test cases for invalid user input >=20 > Signed-off-by: androvonx95 > Reviewed by: imp > Pull Request: https://github.com/freebsd/freebsd-src/pull/1768 ... This commit is broken: - The test regexes don=E2=80=99t match what the program outputs. - A number of test cases were added, but not connected in = `atf_init_test_cases`. - There=E2=80=99re some dead code paths/double warnx calls which add = noise to the program output. I think it would be a good idea to revert the commit, fix the issues, = then resubmit the change once the issues with the submission have been = resolved. Thank you, -Enji PS Sorry for recommending you repro the issue with ghpr =E2=80=94 this = wouldn=E2=80=99t have likely happened had you not pushed changes that = weren=E2=80=99t 100% tested/complete.= --Apple-Mail=_C58533D5-FB50-4324-9D32-ABDEEAAA30CE Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEkHfexGRJ3gYRdA2gGpE5DjPsNJgFAmoqN0QACgkQGpE5DjPs NJgi3A//a89QpPQIfDDN2G6wDMfObx3mS7rj0l8cj/mRJzr8/82qjDCaL6QjLMDv 94C0x3Th31pBkE7BAiwssOy5n2nUIk+AGWNU9e8WdA1KvIcFUxKUlF6DxCFL+lZ5 U2i/EWoMrEVYHPEk++kURuQOyL0pRR52WS6sSE7fsRN0M4KbEkyPbL16p10ftjhD Yv1ePZsoDvvapetYID+PLOAZDzdbkpY3VighvLDU36/MTfz1vvy3HzlBoCF0eM3x FEP0g+EG2uiJ2TDjrRkuXssjZxQCnIT33MytHSrzcIZ6Wzrzm/0ge7A0otxSHhIF UtddgfJEgi99R8VGIjiz7rkctYkl4BZ+meoQwP+2WZAyhwyht/Fce80b27TqIrNl 2W1/qico49Y9zZcIHYcr0lh95vLIdBfh+mtPiDFENUxCUv//a4Neuv2m0ZHx2MJP 3LKj6WxbLxh8OgKPzBYizcGJfmtoJayEuZfFTT5NB6/yKY9Vew9HzpCAHtQ2+Dru +pIlvxwqn/rTilX2HqMZ3SbCDWfDGAc+UscqmcLKc+f7fVR8L6v9zw/GMw9EG1eg nUJ2G5GBIUXWENr91Omx6SUwNvLsJD4ONDxwurDjNENA6t8/ja9YSYz8jmwAGsl0 wz4/yG8bLz3b9+At3n8qgqhT0Xqdxk63lbplgP/b9sExqBGRly0= =RAsP -----END PGP SIGNATURE----- --Apple-Mail=_C58533D5-FB50-4324-9D32-ABDEEAAA30CE--