From owner-cvs-all  Fri Dec 27 12:22: 4 2002
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 180D637B401; Fri, 27 Dec 2002 12:22:03 -0800 (PST)
Received: from rwcrmhc51.attbi.com (rwcrmhc51.attbi.com [204.127.198.38])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 252F143E4A; Fri, 27 Dec 2002 12:22:02 -0800 (PST)
	(envelope-from julian@elischer.org)
Received: from InterJet.elischer.org (12-232-168-4.client.attbi.com[12.232.168.4])
          by rwcrmhc51.attbi.com (rwcrmhc51) with ESMTP
          id <20021227202156051006hqfhe>; Fri, 27 Dec 2002 20:21:56 +0000
Received: from localhost (localhost.elischer.org [127.0.0.1])
	by InterJet.elischer.org (8.9.1a/8.9.1) with ESMTP id MAA12196;
	Fri, 27 Dec 2002 12:21:52 -0800 (PST)
Date: Fri, 27 Dec 2002 12:21:51 -0800 (PST)
From: Julian Elischer <julian@elischer.org>
To: Nate Lawson <nate@root.org>
Cc: Julian Elischer <julian@FreeBSD.org>, cvs-all@freebsd.org,
	cvs-committers@freebsd.org
Subject: Re: cvs commit: src/sys/netgraph ng_fec.c
In-Reply-To: <Pine.BSF.4.21.0212271047480.78794-100000@root.org>
Message-ID: <Pine.BSF.4.21.0212271220440.12006-100000@InterJet.elischer.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
List-ID: <cvs-all.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20cvs-all>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20cvs-all>
X-Loop: FreeBSD.ORG

I guess so, but I am making 5.0 match -current.
I will fix -current but as this works I will leave it alone in 5.0
as that's what's been tested until now.


On Fri, 27 Dec 2002, Nate Lawson wrote:

> On Mon, 23 Dec 2002, Julian Elischer wrote:
> >   Modified files:
> >     sys/netgraph         ng_fec.c 
> >   Log:
> >   Make ng_fec.c compile again since Sam's changes.
> >   
> >   Submitted by:   Hiten Pandya (hiten@unixdaemons.com)
> >   
> >   Revision  Changes    Path
> >   1.3       +8 -5      src/sys/netgraph/ng_fec.c
> > 
> > @@ -188,6 +188,10 @@
> >  static void	ng_fec_print_ioctl(struct ifnet *ifp, int cmd, caddr_t data);
> >  #endif
> >  
> > +/* ng_ether_input_p - see sys/netgraph/ng_ether.c */
> > +extern void (*ng_ether_input_p)(struct ifnet *ifp, struct mbuf **mp,
> > +			struct ether_header *eh);
> > +
> 
> Shouldn't that be a prototype in a .h if it's a public interface?
> 
> -Nate
> 
> 


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message