From nobody Wed Aug 10 14:53:06 2022 X-Original-To: ports@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4M2tGl0Mdtz4Z2Nq for ; Wed, 10 Aug 2022 14:53:19 +0000 (UTC) (envelope-from ros@bebik.net) Received: from smtp.osorio.me (mvd.osorio.me [5.196.94.126]) by mx1.freebsd.org (Postfix) with ESMTP id 4M2tGk0YHHz40m8 for ; Wed, 10 Aug 2022 14:53:17 +0000 (UTC) (envelope-from ros@bebik.net) Received: from [192.168.75.137] (ns3309494.ip-5-135-160.eu [5.135.160.30]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp.osorio.me (Postfix) with ESMTPSA id B529F175BE7 for ; Wed, 10 Aug 2022 14:53:09 +0000 (UTC) Content-Type: multipart/alternative; boundary="------------70ywaqr80SWJiJZr2WhlF8n3" Message-ID: <12183ec9-f711-5fd8-8289-f1d9ef516451@bebik.net> Date: Wed, 10 Aug 2022 16:53:06 +0200 List-Id: Porting software to FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-ports List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-ports@freebsd.org X-BeenThere: freebsd-ports@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [www/chimeracord] port of my unofficial discord client Content-Language: en-US To: ports@freebsd.org References: From: Rodrigo Osorio In-Reply-To: X-Rspamd-Queue-Id: 4M2tGk0YHHz40m8 X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of ros@bebik.net designates 5.196.94.126 as permitted sender) smtp.mailfrom=ros@bebik.net X-Spamd-Result: default: False [-3.20 / 15.00]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_SHORT(-1.00)[-1.000]; R_SPF_ALLOW(-0.20)[+mx]; RCVD_NO_TLS_LAST(0.10)[]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; MLMMJ_DEST(0.00)[ports@freebsd.org]; R_DKIM_NA(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; ASN(0.00)[asn:16276, ipnet:5.196.0.0/16, country:FR]; MIME_TRACE(0.00)[0:+,1:+,2:~]; DMARC_NA(0.00)[bebik.net]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCPT_COUNT_ONE(0.00)[1]; FROM_HAS_DN(0.00)[]; ARC_NA(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; TO_DN_NONE(0.00)[]; PREVIOUSLY_DELIVERED(0.00)[ports@freebsd.org]; MID_RHS_MATCH_FROM(0.00)[] X-ThisMailContainsUnwantedMimeParts: N This is a multi-part message in MIME format. --------------70ywaqr80SWJiJZr2WhlF8n3 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 8/10/22 15:56, Fernando wrote: > I made an unofficial discord using electron and wanting to put it in > the official freeBSD repositories, > it stages, installs, and packages with no issues, I even have a > pre-built binary, > > > git (port): https://github.com/RoboChimera/ChimeraCordBSDPORTS > git (source): https://github.com/RoboChimera/ChimeraCord Hi Fernando, Thanks for you submission, I take a quick look and see a couple of missing stuffs such as the distfile location. To make it simple I chose to use the the github facility. Just by adding the following lines after the BUILD_DEPENDS bloc: * USE_GITHUB= yes GH_ACCOUNT= RoboChimera GH_PROJECT= ChimeraCord GH_TAGNAME= 1ed63ff After that there is some changes to do in the install script, to start, no need to perform the git clone, USE_GITHUB does it for you. After that there is a couple of fixes to do in the install process when you can use variable such as WRKSRC. I recommend you to take a look at the porter handbook, to see how to improve your port (https://docs.freebsd.org/en/books/porters-handbook) Also, you can submit a review of your port using our phabricator (https://reviews.freebsd.org/) the details about how to use are here: https://wiki.freebsd.org/Phabricator. Happy hacking, -- rodrigo --------------70ywaqr80SWJiJZr2WhlF8n3 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 8bit
On 8/10/22 15:56, Fernando wrote:
I made an unofficial discord using electron and wanting to put it in the official freeBSD repositories,
it stages, installs, and packages with no issues, I even have a pre-built binary,


Hi Fernando,

Thanks for you submission, I take a quick look and see
a couple of missing stuffs such as the distfile location.
To make it simple I chose to use the the github facility.

Just by adding the following lines after the BUILD_DEPENDS bloc:

  • USE_GITHUB= yes
    GH_ACCOUNT= RoboChimera
    GH_PROJECT= ChimeraCord
    GH_TAGNAME= 1ed63ff

After that there is some changes to do in the install script,
to start, no need to perform the git clone, USE_GITHUB does it
for you.

After that there is a couple of fixes to do in the install process
when you can use variable such as WRKSRC.


I recommend you to take a look at the porter handbook, to see how to
improve your port (https://docs.freebsd.org/en/books/porters-handbook)

Also, you can submit a review of your port using our phabricator
(https://reviews.freebsd.org/) the details about how to use are here:
https://wiki.freebsd.org/Phabricator.

Happy hacking,
-- rodrigo

--------------70ywaqr80SWJiJZr2WhlF8n3--