From owner-svn-ports-all@FreeBSD.ORG  Tue Aug 20 11:58:58 2013
Return-Path: <owner-svn-ports-all@FreeBSD.ORG>
Delivered-To: svn-ports-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTP id B58501DC;
 Tue, 20 Aug 2013 11:58:58 +0000 (UTC)
 (envelope-from freebsd.contact@marino.st)
Received: from shepard.synsport.net (mail.synsport.com [208.69.230.148])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mx1.freebsd.org (Postfix) with ESMTPS id 8D6392915;
 Tue, 20 Aug 2013 11:58:57 +0000 (UTC)
Received: from [10.31.9.192] (unknown [213.225.137.129])
 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by shepard.synsport.net (Postfix) with ESMTP id 143A7438BE;
 Tue, 20 Aug 2013 06:58:43 -0500 (CDT)
Message-ID: <521359E7.2020008@marino.st>
Date: Tue, 20 Aug 2013 13:58:31 +0200
From: John Marino <freebsd.contact@marino.st>
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64;
 rv:17.0) Gecko/20130509 Thunderbird/17.0.6
MIME-Version: 1.0
To: Andrej Zverev <az@FreeBSD.org>
Subject: Re: svn commit: r325041 - head/japanese/eb
References: <201308201148.r7KBmYcU083251@svn.freebsd.org>
In-Reply-To: <201308201148.r7KBmYcU083251@svn.freebsd.org>
X-Enigmail-Version: 1.5.2
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org,
 ports-committers@freebsd.org
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
Reply-To: marino@freebsd.org
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 20 Aug 2013 11:58:58 -0000

On 8/20/2013 13:48, Andrej Zverev wrote:
> Author: az
> Date: Tue Aug 20 11:48:33 2013
> New Revision: 325041
> URL: http://svnweb.freebsd.org/changeset/ports/325041
> 
> Log:
>   - Conver to new perl5 framework.
>   - Remove duplication of 'USES=gettext'.

> Modified: head/japanese/eb/Makefile
> ==============================================================================
> --- head/japanese/eb/Makefile	Tue Aug 20 11:43:44 2013	(r325040)
> +++ head/japanese/eb/Makefile	Tue Aug 20 11:48:33 2013	(r325041)
> @@ -65,8 +65,7 @@ PORTDOCS=	eb-01.html eb-02.html eb-03.ht
>  
>  USE_AUTOTOOLS=	libtool
>  USE_BZIP2=	yes
> -USES=		gettext
> -USE_PERL5=	yes
> +USES=		gettext perl5
>  GNU_CONFIGURE=	yes
>  USE_LDCONFIG=	yes
>  CONFIGURE_ARGS=	--with-pkgdocdir=${DOCSDIR}
> @@ -78,7 +77,6 @@ APPENDIXDIR=	${DATADIR}/appendix
>  .include <bsd.port.options.mk>
>  
>  .if ${PORT_OPTIONS:MNLS}
> -USES+=		gettext
>  CONFIGURE_ARGS+=	--enable-nls \
>  		--with-gettext-includes=${LOCALBASE}/include \
>  		--with-gettext-libraries=${LOCALBASE}/lib \
> 

Andrej,

I think you fixed gettext usage incorrectly.
>From this diff, you should not have removed USES+= gettext from the NLS
options.

You should have removed USES=gettext on line 68 though.
It's used conditionally.  If you don't have NLS option set on, you don't
need gettext.

Regards,
John