Date: Wed, 5 Mar 2003 10:00:03 -0800 (PST) From: "Simon 'portlint' Schubert" <corecode@corecode.ath.cx> To: freebsd-ports-bugs@FreeBSD.org Subject: Re: ports/48948: New port: devel/tclhaskell-ghc, Tcl/Tk binding for the Glasgow Haskell Compiler Message-ID: <200303051800.h25I03FU014854@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR ports/48948; it has been noted by GNATS.
From: "Simon 'portlint' Schubert" <corecode@corecode.ath.cx>
To: Volker Stolz <stolz@i2.informatik.rwth-aachen.de>
Cc: FreeBSD-gnats-submit@FreeBSD.org, obraun@FreeBSD.org
Subject: Re: ports/48948: New port: devel/tclhaskell-ghc, Tcl/Tk binding for
the Glasgow Haskell Compiler
Date: Wed, 5 Mar 2003 18:59:28 +0100
--bD?ay'NS=.QKqjvJ
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Lately Volker Stolz told:
> sed 's/^X//' >hs-tclhaskell-ghc/Makefile << 'END-of-hs-tclhaskell-ghc/Makefile'
[...]
> XGHC_VERSION= `${PREFIX}/bin/ghc --numeric-version`
> XGHC_LIB= ${PREFIX}/lib/ghc-${GHC_VERSION}
> XPLIST_SUB+= GHC_VERSION="${GHC_VERSION}"
you want ${LOCALBASE}, not ${PREFIX}
> Xpost-patch:
> X ${REINPLACE_CMD} -e s,/local.*tclhaskell,${GHC_LIB}, ${WRKSRC}/Makefile
i don't think it's a good idea NOT to escape shell special characters;
how about:
${REINPLACE_CMD} -e "s,/local.*tclhaskell,${GHC_LIB}," ${WRKSRC}/Makefile
> Xpost-install:
> X @${MKDIR} ${EXAMPLESDIR}
> X @${CP} -pr ${WRKSRC}/../licence.txt ${WRKSRC}/../demo/* ${EXAMPLESDIR}/
${CP} considered harmful. just produces bad ownerships when not building
as root.
consider ${INSTALL_DATA}?
[...]
> X @${SED} -e s,GHC_VERSION,${GHC_VERSION}, <pkg-install.in > pkg-install
don't assume ${.CURDIR} is writeable. use ${WRKDIR} instead:
PKGINSTALL=${WRKDIR}/pkg-install
[...]
@${SED} -e "s,GHC_VERSION,${GHC_VERSION}," \
< ${MASTERDIR}/pkg-install.in > ${PKGINSTALL}
> X PKG_PREFIX=${PREFIX} ${SH} ./pkg-install dummy POST-INSTALL
don't use ./, use ${.CURDIR} instead (or follow thought above and use
${PKGINSTALL}. also consider using ${SETENV}
..
> sed 's/^X//' >hs-tclhaskell-ghc/pkg-install.in << 'END-of-hs-tclhaskell-ghc/pkg-install.in'
> X#!/bin/sh
> X
> XGHC_LIB=$PKG_PREFIX/lib/ghc-GHC_VERSION
.. OR
detect ghc_version in pkg-install again...
cheers
simon
--
/"\ http://corecode.ath.cx/#donate
\ /
\ ASCII Ribbon Campaign
/ \ Against HTML Mail and News
--bD?ay'NS=.QKqjvJ
Content-Type: application/pgp-signature
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (FreeBSD)
iD8DBQE+ZjsDr5S+dk6z85oRAtWLAKDMOlnuj3xjBsojIJehMuMZa3KoEwCeOqcr
JIB6NkH8XcIgtZcfkqcd97Y=
=aBri
-----END PGP SIGNATURE-----
--bD?ay'NS=.QKqjvJ--
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports-bugs" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200303051800.h25I03FU014854>