From owner-freebsd-current@FreeBSD.ORG  Wed Jul 18 03:39:54 2007
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
X-Original-To: freebsd-current@freebsd.org
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 5648F16A400
	for <freebsd-current@freebsd.org>; Wed, 18 Jul 2007 03:39:54 +0000 (UTC)
	(envelope-from jroberson@chesapeake.net)
Received: from webaccess-cl.virtdom.com (webaccess-cl.virtdom.com
	[216.240.101.25])
	by mx1.freebsd.org (Postfix) with ESMTP id 0C15D13C481
	for <freebsd-current@freebsd.org>; Wed, 18 Jul 2007 03:39:53 +0000 (UTC)
	(envelope-from jroberson@chesapeake.net)
Received: from [192.168.1.101] (c-71-231-138-78.hsd1.or.comcast.net
	[71.231.138.78]) (authenticated bits=0)
	by webaccess-cl.virtdom.com (8.13.6/8.13.6) with ESMTP id
	l6I3dpwe041304
	(version=TLSv1/SSLv3 cipher=DHE-DSS-AES256-SHA bits=256 verify=NO);
	Tue, 17 Jul 2007 23:39:53 -0400 (EDT)
	(envelope-from jroberson@chesapeake.net)
Date: Tue, 17 Jul 2007 20:43:08 -0700 (PDT)
From: Jeff Roberson <jroberson@chesapeake.net>
X-X-Sender: jroberson@10.0.0.1
To: "YAMAMOTO, Taku" <taku@tackymt.homeip.net>
In-Reply-To: <20070718111929.22bf3eb3.taku@tackymt.homeip.net>
Message-ID: <20070717204222.I561@10.0.0.1>
References: <20070718111929.22bf3eb3.taku@tackymt.homeip.net>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
Cc: freebsd-current@freebsd.org
Subject: Re: critical_exit(), td_owepreempt and SW_PREEMPT
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 18 Jul 2007 03:39:54 -0000


On Wed, 18 Jul 2007, YAMAMOTO, Taku wrote:

> Greetings,
>
> I had found that critical_exit() calls mi_switch() without SW_PREEMPT
> when td_owepreempt is set.
>
> Should the first argument at that line be SW_INVOL|SW_PREEMPT?

Yes, you're right.  I'll test later and see how this effects perf.  It 
might be an improvement although in most cases there isn't very much 
preempting going on.

Thanks,
Jeff

>
>
> -- 
> YAMAMOTO, Taku <taku@tackymt.homeip.net>
>