Date: Fri, 25 Apr 2008 13:16:30 +0100 (BST) From: Robert Watson <rwatson@FreeBSD.org> To: Daichi GOTO <daichi@FreeBSD.org> Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/fs/unionfs union_subr.c Message-ID: <20080425131229.C80552@fledge.watson.org> In-Reply-To: <200804250953.m3P9rrpd011741@repoman.freebsd.org> References: <200804250953.m3P9rrpd011741@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, 25 Apr 2008, Daichi GOTO wrote: > daichi 2008-04-25 09:53:52 UTC > > FreeBSD src repository > > Modified files: > sys/fs/unionfs union_subr.c > Log: > o Improved unix socket connection issue > fixed: kern/118346 > > PR: kern/118346 > Submitted by: Masanori OZAWA (ozawa@ongs.co.jp) > MFC after: 1 week Goto-san, Per my earlier e-mail, and assuming I understand correctly, I feel not only will this lead to new panics (due to dangling socket pointers and incomplete garbage collection), but it will also lead to possibly incorrect semantics for unionfs (upper layers can write to objects readable via the lower layer). Some parts of this patch are fine, but the copying of v_socket pointers between layers is not correct. Please consider backing that part of the change out. Thanks, Robert N M Watson Computer Laboratory University of Cambridge
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20080425131229.C80552>