From owner-svn-src-head@freebsd.org Wed Mar 29 19:35:55 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 5320CD24627; Wed, 29 Mar 2017 19:35:55 +0000 (UTC) (envelope-from carpeddiem@gmail.com) Received: from mail-it0-x243.google.com (mail-it0-x243.google.com [IPv6:2607:f8b0:4001:c0b::243]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 1D0AC3E8; Wed, 29 Mar 2017 19:35:55 +0000 (UTC) (envelope-from carpeddiem@gmail.com) Received: by mail-it0-x243.google.com with SMTP id w11so3459502itb.0; Wed, 29 Mar 2017 12:35:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=9d68qLsy5PoFrPox4ycuFsNPW44NrkIoMQgkDVaOK00=; b=QNB2Rr/sk6fWhwug9zgNj3MFh3B3E3eJjJhGPSUmrldW9Q3Qza7nrLpVv+POKv+wrU EWhMbFvjrcua4tUcj4WLpTqKFN5NEShfNLs24suFl17EbjVJg7XZjag3wgwTyr1ZWSGN gZdz1m/IGf/mlSptPMihZOC8eOtrMIzu82t3/qW7n7LkUiKdi6hD+WBNneEntGWGFEZ3 AgB81ZckhUCHIG7ncX9UjnGFXVi9y2nbop0WmgVCGwSFZ0D0kf7M1KKTsZMd3PSscmHf 1ix3Cvv9QtVT+Iege2wEzWs9BKZINe2r7+OBFA3d70CG+8AI8Er384411VeaXbIEhqwl k2RA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=9d68qLsy5PoFrPox4ycuFsNPW44NrkIoMQgkDVaOK00=; b=LJv8Y+qL4ceziG8E4u9hoSjPIRVKVx6XUoe+wxV8fPKAwFxsp4MTf+NkVJo6tNOEt8 /6f4OamCJ9XMf7G0fO+fibuht4DBOkdMkXU5PLv8gN9EoSdDn1y0CkDiDzD0pTPa5GAQ xueo0s6U7ydkwKBrnXqKyTfEu4yqaOwdNyjx/uz39nbmtpir6qgyEdBvjhvnqz+xFzut 0vxU0KwJE+/Ih8S7gwv8n+rWHNJW2bX7DgMdlbxIQnE33d+AMLNCmi0IwoqLcNNevb4d uqTX3EOdqqx5aBM5N/8LcVrCp60UmMQGBj8d2rJrkfiaGWdh3nAMYnp5Nx9aqlK09ohg Yuzw== X-Gm-Message-State: AFeK/H0Mw2WUslw5ZJfUQy2Ax6Oky7ZJjFfcUqiWEH3SMXCz9BnBuk9Kp/0zWSnhLwIm/wNUbyHG0XZWRb42Dg== X-Received: by 10.36.0.198 with SMTP id 189mr109840ita.82.1490816154204; Wed, 29 Mar 2017 12:35:54 -0700 (PDT) MIME-Version: 1.0 Sender: carpeddiem@gmail.com Received: by 10.107.30.209 with HTTP; Wed, 29 Mar 2017 12:35:33 -0700 (PDT) In-Reply-To: <201612192028.uBJKSRs4056590@repo.freebsd.org> References: <201612192028.uBJKSRs4056590@repo.freebsd.org> From: Ed Maste Date: Wed, 29 Mar 2017 15:35:33 -0400 X-Google-Sender-Auth: IrYGhEjHJagt2Ey6deYwi9cpCT8 Message-ID: Subject: Re: svn commit: r310295 - in head/sys: conf dev/bhnd/nvram modules/bhnd To: "Landon J. Fuller" Cc: "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Mar 2017 19:35:55 -0000 On 19 December 2016 at 15:28, Landon J. Fuller wrote: > Author: landonf > Date: Mon Dec 19 20:28:27 2016 > New Revision: 310295 > URL: https://svnweb.freebsd.org/changeset/base/310295 > > Log: > bhnd(4): NVRAM device path support. > > Implements bhnd_nvram_store support for parsing and operating over NVRAM > device paths, and device path aliases, as well as tracking per-path NVRAM > variable writes. > @@ -871,13 +881,45 @@ bhnd_nvram_sprom_getvar(struct bhnd_nvra > if ((var->flags & BHND_NVRAM_VF_IGNALL1) && all_bits_set) > return (ENOENT); > > + /* Provide value wrapper */ > + return (bhnd_nvram_val_init(val, var->fmt, inp, ilen, var->type, > + BHND_NVRAM_VAL_BORROW_DATA)); > + return (error); > +} The extra return here seems odd; Coverity picked it up as CID 1373118.