From owner-freebsd-wireless@FreeBSD.ORG Sat Aug 3 21:21:04 2013 Return-Path: Delivered-To: freebsd-wireless@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id A81FA93 for ; Sat, 3 Aug 2013 21:21:04 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: from mail-we0-x22a.google.com (mail-we0-x22a.google.com [IPv6:2a00:1450:400c:c03::22a]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 37CA12E4C for ; Sat, 3 Aug 2013 21:21:04 +0000 (UTC) Received: by mail-we0-f170.google.com with SMTP id w60so1484263wes.15 for ; Sat, 03 Aug 2013 14:21:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type; bh=7bwq7yPsHwQls7BHsyPl+IOh8lD0iYCVOCeLHax9buc=; b=KkVICvpqv/ZSt5iV4EEKCN3DG4kLC/XBeEhE6Q2YWWh1Yuy8l7oBT6xpJgZHQSc90m Y7Qpkzqs7jTyHUKZWFli1yEC54MRDgmZGJuK4J6HFoToocYbPhHeNy0kxhPeCSo5agbp KrrmJSd1KrZuK6EHL/1Y9Z/HqKxdJv8Bv2epW/ip3mdld0VEnw1/ExwsSppxhA5ZD9hj 2MQ87n1YQVG9xAlt9UqEYxLZ0kWzN84e8pxzhMYKzWMu5D1ubCC9e8Q+WwlJ5ma5Gh4r RaBlzto/MA5Ys3RUnKYZ3PbChSvDTrZnlTh//5y5PwuTBpUD2uF3jfbZr57AkQZ/nd9r QkdQ== MIME-Version: 1.0 X-Received: by 10.180.211.206 with SMTP id ne14mr2533060wic.30.1375564862478; Sat, 03 Aug 2013 14:21:02 -0700 (PDT) Sender: adrian.chadd@gmail.com Received: by 10.217.94.132 with HTTP; Sat, 3 Aug 2013 14:21:02 -0700 (PDT) In-Reply-To: <003501ce908e$2e9d2750$8bd775f0$@info> References: <51f3f0ce.055a420a.2e1e.fffff220SMTPIN_ADDED_BROKEN@mx.google.com> <002d01ce8c46$a13b23d0$e3b16b70$@info> <002701ce8e03$c033f640$409be2c0$@info> <002401ce8f5f$fc5ad780$f5108680$@info> <001001ce903b$e77a5f70$b66f1e50$@info> <001e01ce907e$f1daf220$d590d660$@info> <003201ce9081$b401a270$1c04e750$@info> <003501ce908e$2e9d2750$8bd775f0$@info> Date: Sat, 3 Aug 2013 14:21:02 -0700 X-Google-Sender-Auth: McUQhP9wi2Zrd0gCJMJTWsHRhCc Message-ID: Subject: Re: [IWN] Reviw split 2 From: Adrian Chadd To: Cedric GROSS Content-Type: text/plain; charset=ISO-8859-1 Cc: freebsd-wireless@freebsd.org X-BeenThere: freebsd-wireless@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Discussions of 802.11 stack, tools device driver development." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 03 Aug 2013 21:21:04 -0000 Nah, let's take it easier for now. Just leave the trace flags where they are in your diff, remove the flags check so the debug mask works the way it is, and submit a diff with _just_ the remaining debug flags line changes. That way we know what the required changes are, it will only bug people doing active testing (ie, you, me and -wireless) and we have the flags there for when we do sit down and figure out the right way to do trace debugging. Let's get these debug flags for trace in the tree, shorten the diff, and move onto the next set of structural changes. -adrian