From owner-svn-src-head@FreeBSD.ORG Wed Mar 21 16:28:13 2012 Return-Path: Delivered-To: svn-src-head@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 979CF1065674; Wed, 21 Mar 2012 16:28:13 +0000 (UTC) (envelope-from brde@optusnet.com.au) Received: from mail06.syd.optusnet.com.au (mail06.syd.optusnet.com.au [211.29.132.187]) by mx1.freebsd.org (Postfix) with ESMTP id 2FA5D8FC1B; Wed, 21 Mar 2012 16:28:12 +0000 (UTC) Received: from c211-30-171-136.carlnfd1.nsw.optusnet.com.au (c211-30-171-136.carlnfd1.nsw.optusnet.com.au [211.30.171.136]) by mail06.syd.optusnet.com.au (8.13.1/8.13.1) with ESMTP id q2LGS4QC032488 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 22 Mar 2012 03:28:05 +1100 Date: Thu, 22 Mar 2012 03:28:04 +1100 (EST) From: Bruce Evans X-X-Sender: bde@besplex.bde.org To: Marius Strobl In-Reply-To: <201203210850.q2L8olCj062739@svn.freebsd.org> Message-ID: <20120322031550.O2453@besplex.bde.org> References: <201203210850.q2L8olCj062739@svn.freebsd.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r233273 - head/sys/conf X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Mar 2012 16:28:13 -0000 On Wed, 21 Mar 2012, Marius Strobl wrote: > Log: > Exclude devices which are mutually exclusive with ATA_CAM. For better > or worse, the former are still built as modules as part of the LINT > builds > > Reviewed by: mav > MFC after: 1 week This breaks NOTES on these devices. The purpose of NOTES is to test as much as possible, not to provide notes. It is also supposed to test unusual cases. Thus if these unusualy devices actually conflict at compile time, then it is the usual ones that confict that should not be build by NOTES, since the usual ones get adequate testing in GENERIC. > Modified: head/sys/conf/NOTES > ============================================================================== > --- head/sys/conf/NOTES Wed Mar 21 08:43:38 2012 (r233272) > +++ head/sys/conf/NOTES Wed Mar 21 08:50:47 2012 (r233273) > @@ -1715,12 +1715,12 @@ device siis > # For example to build a system which only supports a VIA chipset, > # omit 'ata' and include the 'atacore', 'atapci' and 'atavia' drivers. > device ata > -device atadisk # ATA disk drives > -device ataraid # ATA RAID drives > -device atapicd # ATAPI CDROM drives > -device atapifd # ATAPI floppy drives > -device atapist # ATAPI tape drives > -device atapicam # emulate ATAPI devices as SCSI ditto via CAM > +#device atadisk # ATA disk drives > +#device ataraid # ATA RAID drives > +#device atapicd # ATAPI CDROM drives > +#device atapifd # ATAPI floppy drives > +#device atapist # ATAPI tape drives > +#device atapicam # emulate ATAPI devices as SCSI ditto via CAM > # needs CAM to be present (scbus & pass) > > # Modular ATA > This doesn't change the comment about ATA_CAM, so it is now out of date as well as misformatted. It still says that the ata peripheral devices are (only) deprecated by ATA_CAM, not mutually exclusive. For an example of normal formatting, see the "Internet family" options (except for their unsorting and shouting and misformatting of and in the non-option "WARNING". Another example of misformatting is in the SCHED* options. These have ugly ^L and ################################# delimiters, but are otherwise better formatted than the "Internet family" options. Bruce