From owner-freebsd-hackers Fri Aug 27 3:46:27 1999 Delivered-To: freebsd-hackers@freebsd.org Received: from dorifer.heim3.tu-clausthal.de (dorifer.heim3.tu-clausthal.de [139.174.243.252]) by hub.freebsd.org (Postfix) with ESMTP id 0FB0814DA9 for ; Fri, 27 Aug 1999 03:45:43 -0700 (PDT) (envelope-from olli@dorifer.heim3.tu-clausthal.de) Received: (from olli@localhost) by dorifer.heim3.tu-clausthal.de (8.8.8/8.8.8) id MAA02599 for freebsd-hackers@FreeBSD.ORG; Fri, 27 Aug 1999 12:43:43 +0200 (CEST) (envelope-from olli) Date: Fri, 27 Aug 1999 12:43:43 +0200 (CEST) From: Oliver Fromme Message-Id: <199908271043.MAA02599@dorifer.heim3.tu-clausthal.de> To: freebsd-hackers@FreeBSD.ORG Subject: Re: Request for review: vnconfig.c Organization: Administration Heim 3 Reply-To: freebsd-hackers@FreeBSD.ORG MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8bit X-Newsreader: TIN [version 1.2 RZTUC(3) PL2] Sender: owner-freebsd-hackers@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG Ben Smithurst wrote in list.freebsd-hackers: > Mark J. Taylor wrote: > > + dev = malloc(strlen(vnp->dev)+6); > > + (void)sprintf(dev, "/dev/%s", vnp->dev); > > You should be checking that malloc() doesn't return NULL, before trying > to write into the allocated space. I'd suggest to use asprintf(). Regards Oliver -- Oliver Fromme, Leibnizstr. 18/61, 38678 Clausthal, Germany (Info: finger userinfo:olli@dorifer.heim3.tu-clausthal.de) "In jedem Stück Kohle wartet ein Diamant auf seine Geburt" (Terry Pratchett) To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-hackers" in the body of the message