Date: Tue, 18 Aug 2009 15:19:36 -0700 (PDT) From: Barney Cordoba <barney_cordoba@yahoo.com> To: Xin LI <delphij@delphij.net>, pyunyh@gmail.com Cc: David Christensen <davidch@broadcom.com>, "d@delphij.net" <d@delphij.net>, Julian Elischer <julian@elischer.org>, "freebsd-net@freebsd.org" <freebsd-net@freebsd.org>, Jack Vogel <jfvogel@gmail.com>, Jack F Vogel <jfv@freebsd.org>, yongari@freebsd.org Subject: Re: [PATCH] Fix for e1000 (em/igb) NOARP issue [Was Re: em(4): sending ARP regardless of NOARP flag] Message-ID: <527700.21341.qm@web63902.mail.re1.yahoo.com> In-Reply-To: <20090818214914.GC15025@michelle.cdnetworks.com>
next in thread | previous in thread | raw e-mail | index | archive | help
=0A=0A--- On Tue, 8/18/09, Pyun YongHyeon <pyunyh@gmail.com> wrote:=0A=0A> = From: Pyun YongHyeon <pyunyh@gmail.com>=0A> Subject: Re: [PATCH] Fix for e1= 000 (em/igb) NOARP issue [Was Re: em(4): sending ARP regardless of NOARP fl= ag]=0A> To: "Xin LI" <delphij@delphij.net>=0A> Cc: "Barney Cordoba" <barney= _cordoba@yahoo.com>, "David Christensen" <davidch@broadcom.com>, "d@delphij= ..net" <d@delphij.net>, "freebsd-net@freebsd.org" <freebsd-net@freebsd.org>,= "Jack Vogel" <jfvogel@gmail.com>, "Jack F Vogel" <jfv@freebsd.org>, yongar= i@freebsd.org, "Julian Elischer" <julian@elischer.org>=0A> Date: Tuesday, A= ugust 18, 2009, 5:49 PM=0A> On Tue, Aug 18, 2009 at 02:03:37PM=0A> -0700, X= in LI wrote:=0A> > -----BEGIN PGP SIGNED MESSAGE-----=0A> > Hash: SHA1=0A> = > =0A> > Hi, Jack,=0A> > =0A> > I have looked into the code history and fou= nd that=0A> sys/dev/em/if_em.c,v=0A> > 1.119 has introduced the arp_ifinit(= ) call in order to=0A> fix the problem=0A> > that if_em won't send ARP when= IP address is changed.=0A> > =0A> > I think we can further improve it as a= ttached, say,=0A> only do it when=0A> > IFF_NOARP is not set.=A0 This shoul= d have no effect=0A> for usual=0A> > configuration but fix the problem when= NOARP is the=0A> desired behavior.=0A> > =0A> =0A> That change was introdu= ced by me. I guess the root cause of=0A> the=0A> problem was long initializ= ation time of hardware which in=0A> turn=0A> resulted in unbearable boot ti= me when multiple-alias=0A> addresses are=0A> assigned to em(4). I don't rem= ember details,though.=0A> =0A> Since we're in the release cycle, the change= you suggested=0A> would be=0A> quick fix for 8.0. I think em(4)/igb(4) sho= uld remove=0A> SIOCSIFADDR=0A> handling in driver which is layering violati= on.=0A=0AThere are 2 kinds of programmers; those who do things "correctly',= =0Aand those that do things that work. =0A=0A99.99999% of the people will b= e using ARPs, so don't be silly and=0Abreak the driver to solve a case that= almost no-one cares about please.=0A=0ABarney=0A=0A=0A
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?527700.21341.qm>