From owner-svn-src-head@freebsd.org Tue Apr 19 11:26:14 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 623A5B146AF for ; Tue, 19 Apr 2016 11:26:14 +0000 (UTC) (envelope-from pfg@FreeBSD.org) Received: from nm49-vm6.bullet.mail.bf1.yahoo.com (nm49-vm6.bullet.mail.bf1.yahoo.com [216.109.115.205]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 18E1E1F9F for ; Tue, 19 Apr 2016 11:26:14 +0000 (UTC) (envelope-from pfg@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1461065165; bh=FNmZCqvowfYUaxNiclyL2VqubxTbk7HOjMbZePCfElc=; h=Subject:To:References:Cc:From:Date:In-Reply-To:From:Subject; b=OKhQg5I2uuXVMPVWPaI5ztVzQLXBNnj1L9PPs8G9QM72R3DKrWpNn7Ctf1tulQMd40f4N935WQSjizVz/bCY+vhqtzYIo3XSkMfqWdAmKOhNBNEW9m/C6ljdiBr/wR2JLYFWzMAX4At1CEpdkXLcw4cVXW5JbZ+fT1l7pjKfABWKnIRMGvG/ZHAvm68M1NXJAe+vjS2z3y1lhg+RjmbgAGzBvXASZH/tAavQ6QbfmB24yssGJODWBcm2c/RtULjVed6/fqt3MgEn2ImsBEaQPgtB3aaZSqIHD6DSNgaUFoGaA8VmVSvNzQx25CxwSfdgV3433juOpiPBa7kcs2bOrg== Received: from [98.139.215.143] by nm49.bullet.mail.bf1.yahoo.com with NNFMP; 19 Apr 2016 11:26:05 -0000 Received: from [98.139.213.15] by tm14.bullet.mail.bf1.yahoo.com with NNFMP; 19 Apr 2016 11:26:05 -0000 Received: from [127.0.0.1] by smtp115.mail.bf1.yahoo.com with NNFMP; 19 Apr 2016 11:26:05 -0000 X-Yahoo-Newman-Id: 900901.89945.bm@smtp115.mail.bf1.yahoo.com X-Yahoo-Newman-Property: ymail-3 X-YMail-OSG: FTyZuTYVM1n5OwWedlVNL6kwVcGSknBDNxewjXYFkYm8lEI 65DKUR8Tc5O0DilxiAHQbx7gPlxg2lgTFvnPBtvr8tMFuqWaIvh0MiQTMOHg RYPCVQts74LZemMdl5IhiZA0Pnz0ZtLKP5jYd943RVS.TVXCxANVzxdGNaco ZzQMBg980zJ60RmZJeQ2nRsQW7u0OTLu_jX7GDBMVQlNxj1X.Et2OG71GQGs FjPb1zNgERNXOtlUWx9rqoxIw1npz5lTaO.8Ony8ddKKph7NxgfcqLsQ3yck xmJ1gbAZTse.c9vrdLMDC_ZVP56Gisp5.PgcL_wVSA.bvSjPEyP8gzy5jrdd HX2tSPR0srwAYuVxeQwF39Ys_YNVmNWOsm5Oakf1zcA58jG3wStwoBr6uHUp 3sD8xXNn0I10q2PCfK7JiRePuCa7i6G5xFlNYZg8Sx.Wg8bhq.0LRwJVrPr5 zH_rBDmhwgKSA06p45XUreSV0OUGHcLKCzSKaWPoke4YSt0qF_zBS0PFpNEU AvWlsU6.jMNXCjm7FbNBDojy8adO9dap. X-Yahoo-SMTP: xcjD0guswBAZaPPIbxpWwLcp9Unf Subject: Re: svn commit: r298244 - head/sbin/dumpon To: Steven Hartland , araujo@FreeBSD.org References: <201604190428.u3J4SP2w044552@repo.freebsd.org> <53a3202e-c144-b7d0-02f1-a7f4364d594e@FreeBSD.org> <5715D615.8020806@multiplay.co.uk> Cc: "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" From: Pedro Giffuni Message-ID: Date: Tue, 19 Apr 2016 06:26:08 -0500 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:45.0) Gecko/20100101 Thunderbird/45.0 MIME-Version: 1.0 In-Reply-To: <5715D615.8020806@multiplay.co.uk> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Apr 2016 11:26:14 -0000 On 04/19/16 01:54, Steven Hartland wrote: > > On 19/04/2016 06:01, Marcelo Araujo wrote: >> >> >> 2016-04-19 12:58 GMT+08:00 Pedro Giffuni > >: >> >> >> >> On 04/18/16 23:28, Marcelo Araujo wrote: >> >> Author: araujo >> Date: Tue Apr 19 04:28:25 2016 >> New Revision: 298244 >> URL: https://svnweb.freebsd.org/changeset/base/298244 >> >> Log: >> Use nitems() instead of sizeof(name) / sizeof(*name). >> >> MFC after: 2 weeks. >> >> >> FWIW, while I see why it makes sense to make these cosmetic >> changes, it's probably too much to MFC them. >> >> At least I have no plans to merge the ones I've made since >> they are non-functional. >> >> Pedro. >> >> >> I was thinking to MFC it at once(less work)! As now I'm >> checking/committing one by one. >> > Also not MFC'ing is likely to make it much harder to MFC other > functional changes in the same area, so if they are easy then I'd say do > it :) > That's fine. It's a personal choice. I just don't think many people will be reading the code for dumpon, and if they do they should probably read current anyways ;). Pedro.