From owner-freebsd-arch@FreeBSD.ORG  Mon Jun 16 10:56:43 2003
Return-Path: <owner-freebsd-arch@FreeBSD.ORG>
Delivered-To: freebsd-arch@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 89CC337B401
	for <arch@freebsd.org>; Mon, 16 Jun 2003 10:56:43 -0700 (PDT)
Received: from fledge.watson.org (fledge.watson.org [204.156.12.50])
	by mx1.FreeBSD.org (Postfix) with ESMTP id CD2D043F75
	for <arch@freebsd.org>; Mon, 16 Jun 2003 10:56:42 -0700 (PDT)
	(envelope-from robert@fledge.watson.org)
Received: from fledge.watson.org (localhost [127.0.0.1])
	by fledge.watson.org (8.12.9/8.12.9) with ESMTP id h5GHt0YA008904;
	Mon, 16 Jun 2003 13:55:00 -0400 (EDT)
	(envelope-from robert@fledge.watson.org)
Received: from localhost (robert@localhost)h5GHsxhq008901;
	Mon, 16 Jun 2003 13:54:59 -0400 (EDT)
	(envelope-from robert@fledge.watson.org)
Date: Mon, 16 Jun 2003 13:54:59 -0400 (EDT)
From: Robert Watson <rwatson@freebsd.org>
X-Sender: robert@fledge.watson.org
To: John-Mark Gurney <gurney_j@efn.org>
In-Reply-To: <20030616074122.GF73854@funkthat.com>
Message-ID: <Pine.NEB.3.96L.1030616135002.8726B-100000@fledge.watson.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
cc: arch@freebsd.org
Subject: Re: make /dev/pci really readable
X-BeenThere: freebsd-arch@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Discussion related to FreeBSD architecture
	<freebsd-arch.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-arch>,
	<mailto:freebsd-arch-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-arch>
List-Post: <mailto:freebsd-arch@freebsd.org>
List-Help: <mailto:freebsd-arch-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-arch>,
	<mailto:freebsd-arch-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 16 Jun 2003 17:56:43 -0000


On Mon, 16 Jun 2003, John-Mark Gurney wrote:

> Does anyone have an objection to making /dev/pci really honor the
> permissions, and giving normal users (or just group wheel) premission to
> run pciconf -l.  Right now the code requires the write bit set for any
> operation. 

I seem to recall that there was a problem wherein user processes could
cause cause unaligned accesses using /dev/pci.  There's also some rather
odd use of useracc(), printf(), etc, in the ioctl code.  I suspect this
code needs some fairly thorough review and cleanup before we should reduce
the level of privilege required to use the device (note that we make it
world readable by default, so changes in the semantics of read permissions
will affect all users in the system).  Could you do that cleanup in the
first pass, then revisit the permissions change?

Robert N M Watson             FreeBSD Core Team, TrustedBSD Projects
robert@fledge.watson.org      Network Associates Laboratories